Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add openj9 to the matrix #974
Conversation
This comment has been minimized.
This comment has been minimized.
|
I think it makes sense to add J9 to the test matrix, and it could even make sense to kill one of the jobs in favour of J9. I'm not sure which one to kill though. |
This comment has been minimized.
This comment has been minimized.
|
I killed 2 jobs in #959. |
This comment has been minimized.
This comment has been minimized.
|
#959 is merged, if test with J9 makes sense this can be merged. |
jorsol
force-pushed the
jorsol:openj9-test
branch
from
3b2b1e9
to
3981188
Oct 13, 2017
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Oct 13, 2017
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
============================================
+ Coverage 65.93% 65.94% +<.01%
- Complexity 3560 3561 +1
============================================
Files 166 166
Lines 15244 15244
Branches 2465 2465
============================================
+ Hits 10051 10052 +1
Misses 4022 4022
+ Partials 1171 1170 -1 |
davecramer
merged commit f187645
into
pgjdbc:master
Oct 19, 2017
added a commit
to bolcom/pgjdbc
that referenced
this pull request
Jul 13, 2018
added a commit
to bolcom/pgjdbc
that referenced
this pull request
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jorsol commentedOct 2, 2017
Run tests on Eclipse OpenJ9.
Not sure if we need to test with it. Comments?
Related: #649