node v0.4 #14

Merged
merged 2 commits into from Jul 17, 2012
@jmars

The Buffer class was changed in node v0.4, nodejs/node-v0.x-archive@56074d1

As such, node-msgpack is failing to build, the members were just inlined so an easy fix.

@bcg

+1

@lpgauth

+1

@feoh

+1

@vpereira

+1 i did open an issue because of that. it doesn't compile.

@dshaw

+1 please

@jmars

It's been a month since the last commit. Pushed the fork up onto npm as 'msgpack-0.4' until maintainer returns.

@Fristi

@jmars thanks, thats great!

@c4milo

+1

@aq1018

+1000 plz pull

@eden

+1

@perezd

+1

@aq1018

is this project event being maintained anymore?

@c4milo

It doesn't seem like it is.

@matehat

+1

@devongovett

By the way, just in case you are interested, I have written a pure JS (CoffeeScript actually but it can be used with plain JS) msgpack library for Node because of this issue: https://github.com/devongovett/coffeepack. npm install coffeepack to use it. Check it out!

@devongovett

Perhaps if I can find the time. Sounds like a good pull request to me :)

@walf443

+1 and I wrote more abount node v6.0 or later https://github.com/walf443/node-msgpack/commits/support_node_v6

@godsflaw godsflaw merged commit b9b8f14 into pgriess:master Jul 17, 2012
@godsflaw
Collaborator

I just wanted to let everyone know that this package is maintained again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment