Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support node v6 #22

Merged
merged 5 commits into from Jul 17, 2012

Conversation

Projects
None yet
7 participants
Contributor

walf443 commented Nov 9, 2011

support node v6.0 or later. This changes include jmars's node v4 support.

acacio commented Feb 11, 2012

+1 up-voting this bug/issue.
The node.js support is becoming a bit long in the tooth... :-/

+1

athoune commented Mar 1, 2012

+1

even if it might get compatible with v0.6 sometime, msgpack is no longer faster than plain JSON.parse and JSON.stringify.
Run the benchmarks on your own!

athoune commented Mar 14, 2012

msgpack is not a "faster than JSON", it's more compact and handles raw binary, true flotting point. I don't wont to base64 my JPEG to put it in JSON format. Redis scripting handles msgpack format https://github.com/antirez/lua-cmsgpack , I want to test it from nodejs.

@athoune Excatly. Did not want to say that since it is not faster anymore it should not be used. Just thought to state somewhere that is isn't faster than native JSON anymore for those who used it just because of that reason

@godsflaw godsflaw merged commit 8caf6d6 into pgriess:master Jul 17, 2012

@godsflaw godsflaw added a commit to godsflaw/node-msgpack that referenced this pull request Sep 16, 2015

@godsflaw godsflaw Merge pull request #22 from sdepold/feature/travis
Enable travis builds
608245b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment