Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue 42 #43

Merged
merged 2 commits into from Jun 14, 2013

Conversation

Projects
None yet
2 participants
Contributor

maxtaco commented Feb 26, 2013

The old code had complementary pack and unpack bugs, but it meant this version of msgpack produced packings that differed from proper msgpacks on other platforms.

maxtaco added some commits Feb 26, 2013

This fixes Issue #42 and puts in at least one regression test for 64-bit
integer values, which work in node.js up to about 2^54 and down to
-2^54. May as well make a best effort to get them right.  This issue is
due to a regression introduced in commits  6b4c80c and 0b4f361, which
taken together always encode larger integers as doubles, even when
they shouldn't be.

godsflaw added a commit that referenced this pull request Jun 14, 2013

Merge pull request #43 from maxtaco/issue_42
Since this could change packed/unpacked results, I am going to minor version bump the package once a get a few more things into master.

@godsflaw godsflaw merged commit 0cb4a05 into pgriess:master Jun 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment