Consistent handling of string encoding #2

pgriess opened this Issue Oct 13, 2010 · 1 comment


None yet

2 participants

pgriess commented Oct 13, 2010

A few changes to the API are desirable to make string handling more consistent:

  • Add an optional encoding parameters to the functions that take strings as input.
  • Functions that generate data should return a constant data type: a Buffer. If the caller wants a string, they can deal with that. The problem w/ returning strings is that serializing that out forces the caller to make a decision about encoding, at which point the length prefix can become incorrect.
josh commented Oct 14, 2010

Patches #3

@pgriess pgriess closed this May 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment