A few minor fixes :) #20

Merged
merged 2 commits into from Jan 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

Flameeyes commented Dec 24, 2011

Hi there!

Thanks again for the tag, that helps us a lot. While I was looking at your project I noticed I could improve it a tiny bit, so I made the changes and I'm sending them here :)

They are really minimal, but every bit helps, as they say. They are not worth a new version btw, so you should probably leave them queued for the future.

HTH!
Diego

Flameeyes added some commits Dec 24, 2011

Mark all variables as static.
Since the whole interface required by Ruby is the Init_* function, the
variables can easily not be exposed as symbols, which reduce the chance of
symbol collisions, the size of the symbol table a the number of resolutions
to the PLT.

ph7 added a commit that referenced this pull request Jan 6, 2012

Merge pull request #20 from Flameeyes/master
Code cleanup by Diego Elio Pettenò

@ph7 ph7 merged commit 0f2bc3c into ph7:master Jan 6, 2012

Owner

ph7 commented Jan 6, 2012

Thanks Diego, this is good code cleanup ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment