Skip to content

Pier-Hugues Pellerin
ph

Developer Program Member

Organizations

@elastic
Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

I did another pass @spinscale !

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Yeah, well I change the expectation to do a more in details check between all the messages. It make more sense. In a future version we could random…

Jun 30, 2016
@ph
  • @ph af76887
    More small update from the review
Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

I don't really know upfront before serializing (json or fields), Any recommandation. Any idea how I could approximate that value?

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

make sense doing it.

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

I will change the expectation and the setup of the test to make it more clear.

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

good catch

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Only used in the BeatsParserTest

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Currently these is no generic name for it, I will recheck with the team if it changed.

Jun 30, 2016
@ph
  • @ph 9abb0a6
    Use internal netty classes to make sure we dont copies bytes all over
  • @ph 846630a
    Set a size for the hash map when dealing with v1 protocol
  • 1 more commit »
Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

@jordansissel What do you think we should do in that case? Log the event and go on?

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

From the doc, I pretty sure I read that buffer will be release when the write occur?

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

This would require changes to the clients to have more bidirectional messages. So for the first implementation I think we are fine.

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Agree

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

wonderful will make the changes!

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Thats a pretty good question, in the current implementation the following will happen: An exception will be raised The handler will catch it log it.

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Oh crap forgot about that.

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

@spinscale Correct I will make a PR for core to have it by default in the api.

Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

From a discussion on zoom @spinscale and I agreed to do the following next steps to make sure the netty implementation is ready. Create a stress t…

Jun 30, 2016
@ph
  • @ph 962a424
    change link to FB artifact
Jun 30, 2016
ph commented on pull request logstash-plugins/logstash-filter-geoip#83
@ph

This should be fixed, but it probably require a new snapshot release of the core for the test to pass?

Jun 30, 2016
@ph
Add metrics info
2 commits with 12 additions and 3 deletions
Jun 30, 2016
@ph
Add metrics info
Jun 30, 2016
ph commented on issue elastic/logstash#5539
@ph

done in #5544

Jun 30, 2016
ph closed issue elastic/logstash#5539
@ph
Backport null metrics to 2.4
Jun 30, 2016
@ph
  • @ph cb0f654
    3.1.0 initial change note and reformat of the changelog
Jun 30, 2016
ph opened issue elastic/logstash#5575
@ph
Plugins Manager in 5.X and beyond.
Jun 29, 2016
@ph
  • @ph 78887bc
    Make sure the jar-dep directory exist.
Jun 29, 2016
ph commented on pull request logstash-plugins/logstash-input-beats#93
@ph

Okay, after discussing with @talevy we agreed to change the strategy to make it work on travis.

Something went wrong with that request. Please try again.