Please sign in to comment.
Added missing space between words in messages.
Summary: During my attept to `arc land master` on `master` branch I have discovered that error message is missing few spaces between words. I have added them and used this ugly readonly command: pcregrep --include="\.php$" -M -r '(?<!\\n| )("|'"'"')\.\n\s*\1(?!\\n| )' ~/arc/arcanist/src to detect other instances of this serious bug. Two more were found. This time they were probably introduced in order to abide to the draconian lint rule about number of columns. Since I want to be a good citizen, I have added this missing space to the begining of the next line in both cases. It is an ugly hack, but I think user should not suffer due to missing spaces. Another solution could be preserving no leading spaces and splitting long lines. Or just providing excuse to lint. Test Plan: Ran `arc land master` on `master` branch. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3008 Differential Revision: https://secure.phabricator.com/D5827
- Loading branch information...
Showing with 5 additions and 5 deletions.