Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Changes to Arcanist for libphutil "extensions/"

Summary: See D5714. Ref T2971.

Test Plan: Built a library map for libphutil's test library.

Reviewers: vrana, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2971

Differential Revision: https://secure.phabricator.com/D5715
  • Loading branch information...
commit 904740855c5570ddc13f3d80eded550f192a2175 1 parent c0ff985
@epriestley epriestley authored
View
1  .gitignore
@@ -1,6 +1,7 @@
.DS_Store
._*
/src/.phutil_module_cache
+/src/extensions/*
/docs/
/.divinercache/
/externals/includes/*
View
12 scripts/lib/PhutilLibraryMapBuilder.php
@@ -388,13 +388,6 @@ private function loadSourceFileMap() {
$map = array();
foreach ($files as $file => $hash) {
- if (basename($file) == '__init__.php') {
- // TODO: Remove this once we kill __init__.php. This just makes the
- // script run faster until we do, so testing and development is less
- // annoying.
- continue;
- }
-
$file = Filesystem::readablePath($file, $root);
$file = ltrim($file, '/');
@@ -404,6 +397,11 @@ private function loadSourceFileMap() {
continue;
}
+ if (dirname($file) == 'extensions') {
+ // Ignore files in the extensions/ directory.
+ continue;
+ }
+
// We include also filename in the hash to handle cases when the file is
// moved without modifying its content.
$map[$file] = md5($hash.$file);
View
2  src/extensions/README
@@ -0,0 +1,2 @@
+You can add `.php` files to this directory to load classes and functions defined
+in them at runtime.
Please sign in to comment.
Something went wrong with that request. Please try again.