Permalink
Browse files

Fix arc patch adding unnecessary files for hg repos

Summary:
Arc patch was committing with -A (--addremove) which meant any random
files that were sitting around in the repo (like conflict .orig files) were
added to the commit.  The -A isn't even necessary since the hg import
adds and removes all the appropriate files for you.

Test Plan:
touch foo
arc patch --diff some-diff-id
Verified that foo was not added to the commit

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: dschleimer, bos, sid0, aran, Korvin

Differential Revision: https://secure.phabricator.com/D5396
  • Loading branch information...
1 parent 30e12a0 commit b6e83c7b3523fe62e7ff9c7622a4d6243571edd8 @DurhamG DurhamG committed Mar 20, 2013
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/workflow/ArcanistPatchWorkflow.php
View
2 src/workflow/ArcanistPatchWorkflow.php
@@ -773,7 +773,7 @@ public function run() {
$commit_message = $this->getCommitMessage($bundle);
$future = $repository_api->execFutureLocal(
- 'commit -A %C -l -',
+ 'commit %C -l -',
$author_cmd);
$future->write($commit_message);
$future->resolvex();

0 comments on commit b6e83c7

Please sign in to comment.