Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Add py/pl files to $text_paths (remove l/y files?!)

I'm guessing this was refactored somewhere down the line and it meant
that Python and Perl files were no longer considered text files.

I'm imagining the old regex was: p(hp|y|l). Therefore I blame CSS.

Test Plan:
Perform an arc lint on a Python or Perl file that has trailing whitespace
on a line. It should prompt you for an autocorrecting lint.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision:
  • Loading branch information...
commit cf76d2fc1c5084c8971407afd6c22d59a6a8cdb1 1 parent dbe0f7d
@shayne shayne authored epriestley committed
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/lint/engine/ComprehensiveLintEngine.php
2  src/lint/engine/ComprehensiveLintEngine.php
@@ -23,7 +23,7 @@ public function buildLinters() {
- $text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y)$/', $paths);
+ $text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y|py|pl)$/', $paths);
$linters[] = id(new ArcanistGeneratedLinter())->setPaths($text_paths);
$linters[] = id(new ArcanistNoLintLinter())->setPaths($text_paths);
$linters[] = id(new ArcanistTextLinter())->setPaths($text_paths);
Please sign in to comment.
Something went wrong with that request. Please try again.