Permalink
Browse files

Add missing image functions to PHP extension functions list

Summary:
Copied from PHP Manual.

Also fix missing cache key for implicitly linted file.

Test Plan:
  phabricator/ $ arc lint src/applications/files/PhabricatorImageTransformer.php # without GD2

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan

Differential Revision: https://secure.phabricator.com/D5457
  • Loading branch information...
1 parent 50b4f0a commit d1027c186c1b44e757ea92233d69e60a8cf91f65 @vrana vrana committed Mar 28, 2013
Showing with 18 additions and 1 deletion.
  1. +14 −0 scripts/php_extension_functions.txt
  2. +4 −1 src/workflow/ArcanistLintWorkflow.php
View
14 scripts/php_extension_functions.txt
@@ -111,6 +111,7 @@ imagecreatefrompng
imagecreatefromstring
imagecreatefromwbmp
imagecreatefromxbm
+imagecreatefromxpm
imagecreatetruecolor
imagedashedline
imagedestroy
@@ -124,10 +125,14 @@ imagefilltoborder
imagefilter
imagefontheight
imagefontwidth
+imageftbbox
+imagefttext
imagegammacorrect
imagegd
imagegd2
imagegif
+imagegrabscreen
+imagegrabwindow
imageinterlace
imageistruecolor
imagejpeg
@@ -137,6 +142,13 @@ imageloadfont
imagepalettecopy
imagepng
imagepolygon
+imagepsbbox
+imagepsencodefont
+imagepsextendfont
+imagepsfreefont
+imagepsloadfont
+imagepsslantfont
+imagepstext
imagerectangle
imagerotate
imagesavealpha
@@ -150,6 +162,8 @@ imagestringup
imagesx
imagesy
imagetruecolortopalette
+imagettfbbox
+imagettftext
imagetypes
imagewbmp
imagexbm
View
5 src/workflow/ArcanistLintWorkflow.php
@@ -548,7 +548,10 @@ public function run() {
$cached_path[] = $message->toDictionary();
}
}
- $hash = $file_hashes[$abs_path];
+ $hash = idx($file_hashes, $abs_path);
+ if (!$hash) {
+ $hash = md5_file($abs_path);
+ }
$cached[$path] = array($hash => array($version => $cached_path));
}
$cache[$this->getCacheKey()] = $cached;

0 comments on commit d1027c1

Please sign in to comment.