ArcanistGitAPI: replace 'ls-files -m' with diff-files #121
Conversation
As documented, $ git ls-files -m fails to exclude ignored submodules. Replace it with an equivalent: $ git diff-files --name-only which does not suffer from this defect. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
epriestley
pushed a commit
that referenced
this pull request
Nov 22, 2013
As documented, $ git ls-files -m fails to exclude ignored submodules. Replace it with an equivalent: $ git diff-files --name-only which does not suffer from this defect. See: <#121> Reviewed by: epriestley
|
Cherry-picked as 6033f14. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As documented,
$ git ls-files -m
fails to exclude ignored submodules. Replace it with an equivalent:
$ git diff-files --name-only
which does not suffer from this defect.
Signed-off-by: Ramkumar Ramachandra artagnon@gmail.com