Updating Pylint to send in proper arguments depending on the version #161
Conversation
…g on the version of pylint installed
This comment has been minimized.
This comment has been minimized.
|
By convention, just use |
This comment has been minimized.
This comment has been minimized.
|
Can this just return the full version string? The callsite can then use |
This comment has been minimized.
This comment has been minimized.
|
Can this be private? |
This comment has been minimized.
This comment has been minimized.
|
Some inlines; did you run this against both 0.x and 1.x versions and verify it behaves correctly? I want to make sure this has been tested before pulling it, but can't tell from the request. |
|
I tested this with 1.0.0, 1.2.0, 0.28.0. That's when I realized 1.2.0 works as-is if you change the output format in the rcfile |
epriestley
pushed a commit
that referenced
this pull request
May 6, 2014
…g on the version of pylint installed See: <#161> Reviewed by: epriestley
|
Thanks, cherry-picked as 85000be. |
julkiewicz
added a commit
to julkiewicz/arcanist
that referenced
this pull request
Aug 7, 2015
…g on the version of pylint installed See: <phacility#161> Reviewed by: epriestley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pylint 1.2.0 has been updated to not exit with 32 when -iy is passed in, so these changes could all be set in the rcfile, but it's nice to have pylint work without having a rcfile