Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept int as map key too #163

Closed
wants to merge 1 commit into from
Closed

Accept int as map key too #163

wants to merge 1 commit into from

Conversation

@BYK
Copy link
Contributor

@BYK BYK commented Apr 30, 2014

Accept integers in severity map too since when you pass the following

"text": {
    "type": "text",
    "include": "(\\.*)",
    "severity": {
        "3": "advice"
    }
}

to .arclint it throws an error. Reason is json_decode or PHP itself implicitly casting "3" into an integer 3.

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Apr 30, 2014

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@BYK
Copy link
Contributor Author

@BYK BYK commented Apr 30, 2014

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

Been there done that :)

epriestley pushed a commit that referenced this pull request May 6, 2014
See: <#163>

Reviewed by: epriestley
@epriestley
Copy link
Member

@epriestley epriestley commented May 6, 2014

Bleh. Thanks. Cherry-picked as b4e91e1.

@epriestley epriestley closed this May 6, 2014
@BYK BYK deleted the BYK:fix-map branch May 6, 2014
julkiewicz added a commit to julkiewicz/arcanist that referenced this pull request Aug 7, 2015
See: <phacility#163>

Reviewed by: epriestley
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants