CSS lint support for arcanist using csslint.

[vlajos]

CSS lint support for arcanist using csslint.

[vlajos]

ping.

[epriestley]

I'm a bit hesitant to merge any more external linters until after https://secure.phabricator.com/T2039

The problem is that external linters create a support problem which I don't yet have enough infrastructure to deal with, and adding more tends to exacerbate this problem. There's a small war being waged over one of the Python linters now, where the correct python binary is different on every system. One solution is "add lots of configuration options to every linter", but I think T2039 is preferable.

This code looks correct to me -- how about I try to get T2039 done by Aug 1, and I'll merge this as-is if I can't get it done by then?

[epriestley]

@autocracy, I don't think we've met -- are you a Facebook employee? Can you explain why you merged this? I'm on #phabricator on FreeNode if you want to chat.

[autocracy]

Read code, merge file, check email, oops.

Github doesn't have an unmerge, does it?

On Jul 22, 2013, at 6:44 AM, Evan Priestley wrote:

I'm a bit hesitant to merge any more external linters until after https://secure.phabricator.com/T2039

The problem is that external linters create a support problem which I don't yet have enough infrastructure to deal with, and adding more tends to exacerbate this problem. There's a small war being waged over one of the Python linters now, where the correct python binary is different on every system. One solution is "add lots of configuration options to every linter", but I think T2039 is preferable.

This code looks correct to me -- how about I try to get T2039 done by Aug 1, and I'll merge this as-is if I can't get it done by then?

—
Reply to this email directly or view it on GitHub.

[epriestley]

I'm going to revert this as per #93 (comment)

[vlajos]

Let me know if I can help something.

[epriestley]

It's Aug 2 and I haven't made any progress on generalizing lint, so I'll pull this.

[epriestley]

I'm dropping this from the Comprehensive lint engine in the pull because adding it there turns it on for everyone using that engine with no way to disable it, and that engine is seeing far more use than it was intended to (this is among the reasons that the current approach is bad), and if you don't have csslint installed adding it makes the engine fail. Everything else is going through. Thanks!

[epriestley]

Pulled as a680c55