Permalink
Browse files

JX.Request: Allow raw data + data uploads

Summary:
After D2384, it seems like we should allow raw data uploads + data
(since magic parameters like __ajax__ and __metablock__ are now being
sent as part of the GET query string.

Test Plan:
on the FB code base, send FormData as raw data on JX.Request and see
that the request works. FB code base calls addData on every JX.Request
that is sent so any request with raw data would throw previously.

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3734
  • Loading branch information...
1 parent fee3bb1 commit 59342b22dc4d336736cdf89af8d51fb49e7bb1a9 @paulshen paulshen committed Oct 18, 2012
Showing with 0 additions and 6 deletions.
  1. +0 −6 src/lib/Request.js
View
@@ -107,12 +107,6 @@ JX.install('Request', {
'JX.Request.send(): ' +
'attempting to send post data over GET. You must use POST.');
}
- if (this._data) {
- JX.$E(
- 'JX.Request.send(): ' +
- 'attempting to send data and raw data. You can not send both ' +
- 'at once.');
- }
}
}

0 comments on commit 59342b2

Please sign in to comment.