Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
tree: 1006c35999
Commits on Oct 4, 2012
  1. @epriestley

    Merge pull request #36 from roddylindsay/master

    epriestley authored
    add an enable() method to Typeahead
  2. @roddylindsay

    add enable() method to Typeahead

    roddylindsay authored
    Summary: adds an enable() method to Typeahead.  Use case is the following: I have a tokenizer and when a certain class of tokens is selected I want to disable the typeahead.  When those tokens are removed I want to re-enable the typeahead.
    
    Test Plan: Implemented tokenizer with this behavior
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3617
Commits on Oct 1, 2012
  1. @epriestley

    Respect ports in JX.URI

    epriestley authored
    Summary: durrrrrp
    
    Test Plan: My local install on 8080 works better now. New test passes.
    
    Reviewers: vrana, btrahan
    
    Reviewed By: btrahan
    
    CC: aran
    
    Differential Revision: https://secure.phabricator.com/D3573
Commits on Sep 22, 2012
  1. @rboyce

    Merge pull request #35 from hedgerwang/master

    rboyce authored
    TypeaheadCompositeSource
Commits on Sep 20, 2012
  1. @hedgerwang
  2. @hedgerwang

    Fix JS error from TypeaheadCompositeSource.

    hedgerwang authored
    Summary:
    The callback function childWaiting checks the length of this.result which could
    be null and cause JS error.
  3. @hedgerwang
Commits on Sep 17, 2012
  1. Allow handling dblclick event

    vrana authored
    Test Plan: See D3509.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3508
Commits on Sep 10, 2012
  1. @hedgerwang @epriestley

    Fix Typeahead (regression introduced by commit c59b8ba)

    hedgerwang authored epriestley committed
  2. @hedgerwang
  3. @hedgerwang
  4. @hedgerwang
Commits on Sep 7, 2012
  1. Fix regression introduced by D2960

    Sergio Clemente authored
    Summary:
    D2960 renamed callback to load_callback. Everything was fine except for
    windows phone (Might be the only one using?
    
    Test Plan: Executed the code that was failing now is passing
    
    Reviewers: jeffmo, epriestley, marek
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3454
Commits on Sep 5, 2012
  1. @hedgerwang @epriestley
Commits on Sep 4, 2012
  1. @hedgerwang

    Merge https://github.com/hedgerwang/javelin

    hedgerwang authored
    Conflicts:
    	src/lib/control/typeahead/Typeahead.js
  2. @hedgerwang
  3. @hedgerwang
  4. @hedgerwang
  5. @epriestley
Commits on Aug 31, 2012
  1. @hedgerwang

    Update src/lib/control/typeahead/Typeahead.js

    hedgerwang authored
    Fix the issue that non-result node may be chosen.
Commits on Aug 30, 2012
  1. @epriestley

    Merge pull request #32 from roddylindsay/master

    epriestley authored
    add ability to replace a datasource
  2. @roddylindsay

    Ability to replace the datasource of a typeahead

    roddylindsay authored
    Summary: Adds the ability to swap the datasource of an existing typeahead for a new one
    
    Test Plan: Successfully swapped an on-demand and a preloaded source back and forth within a tokenizer
    
    Reviewers: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3405
Commits on Aug 27, 2012
  1. Revert "Support synchronous requests"

    vrana authored
    Summary:
    According to D3356#8, this is evil even in `onunload`.
    I think it's advantage of the library if it doesn't support evil.
    
    This reverts commit rJX6bcce5.
    
    Test Plan: None.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3384
Commits on Aug 22, 2012
  1. Fix highlighting in docs

    vrana authored
    Summary: This is currently highlighted wrong because two consecutive code block merges together: www.phabricator.com/docs/javelin/article/Concepts_Event_Delegation.html
    
    Test Plan: Generated docs.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3359
  2. Support synchronous requests

    vrana authored
    Summary:
    It is needed in the `unload` handler.
    Maybe we can rename it to `blockBrowserUIUntilTheRequestFinishes`.
    
    Test Plan: Used in D3356.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3358
Commits on Aug 13, 2012
  1. Add getDatasource function for typeahead

    Hendri - authored
    Summary:
    Sometimes we need to access the datasource of typeahead, rather
    than accessing using typeahead._datasource, should we just make a
    getDatasource() function?
    
    Test Plan: test getting the datasource using getDatasource()
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3260
Commits on Aug 10, 2012
  1. @epriestley

    Merge pull request #29 from lifeinafolder/master

    epriestley authored
    Typo in last pull request
  2. @lifeinafolder
  3. @epriestley

    Merge pull request #28 from lifeinafolder/master

    epriestley authored
    Use JX.isArray instead of instanceOf
  4. @lifeinafolder
Commits on Aug 8, 2012
  1. Fix JavaScript syntax error

    vrana authored
Commits on Aug 7, 2012
  1. @epriestley

    Rebuild premade Javelin packages

    epriestley authored
    Summary:
    We include some premade Javelin packages that haven't been rebuild recently. Rebuild them.
    
    This diff was created by running `scripts/rebuild-packages.php`.
    
    Test Plan: Scripted rebuild. Examples work.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3163
  2. @epriestley

    Add an example of complex tokenizer behavior

    epriestley authored
    Summary: See D3143. Depends on D3159, D3160, D3161.
    
    Test Plan: Used example.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3162
  3. @epriestley

    Add a getResult(id) method to TypeaheadSource

    epriestley authored
    Summary:
    In some places, like the `choose` event of JX.Typeahead and the `getTokens()` method of JX.Tokenizer, we return result IDs and some piece of derived data (the node in the former case, the display string in the latter case). In most cases, these are sufficient, if somewhat awkward and possibly poor architectural decisions.
    
    However, sometimes we need the raw result with any additional data it may carry (see D3143). Add a method to do a lookup by ID.
    
    Test Plan: Built an example using this, see D3143.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3161
  4. @epriestley

    Add JX.TypeaheadStaticSource

    epriestley authored
    Summary: Add a completely static source to compliment the existing Ajax sources (preloaded / ondemand), useful for small data or examples.
    
    Test Plan: Built a simple example using this source, see D3143.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3160
Something went wrong with that request. Please try again.