Permalink
Switch branches/tags
Nothing to show
Commits on Sep 10, 2012
Commits on Sep 7, 2012
  1. Fix regression introduced by D2960

    Summary:
    D2960 renamed callback to load_callback. Everything was fine except for
    windows phone (Might be the only one using?
    
    Test Plan: Executed the code that was failing now is passing
    
    Reviewers: jeffmo, epriestley, marek
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3454
    Sergio Clemente committed Sep 7, 2012
Commits on Sep 5, 2012
Commits on Sep 4, 2012
  1. Merge https://github.com/hedgerwang/javelin

    Conflicts:
    	src/lib/control/typeahead/Typeahead.js
    hedgerwang committed Sep 4, 2012
Commits on Aug 31, 2012
  1. Update src/lib/control/typeahead/Typeahead.js

    Fix the issue that non-result node may be chosen.
    hedgerwang committed Aug 31, 2012
Commits on Aug 30, 2012
  1. Merge pull request #32 from roddylindsay/master

    add ability to replace a datasource
    epriestley committed Aug 30, 2012
  2. Ability to replace the datasource of a typeahead

    Summary: Adds the ability to swap the datasource of an existing typeahead for a new one
    
    Test Plan: Successfully swapped an on-demand and a preloaded source back and forth within a tokenizer
    
    Reviewers: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3405
    roddylindsay committed Aug 30, 2012
Commits on Aug 27, 2012
  1. Revert "Support synchronous requests"

    Summary:
    According to D3356#8, this is evil even in `onunload`.
    I think it's advantage of the library if it doesn't support evil.
    
    This reverts commit rJX6bcce5.
    
    Test Plan: None.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3384
    vrana committed Aug 25, 2012
Commits on Aug 22, 2012
  1. Fix highlighting in docs

    Summary: This is currently highlighted wrong because two consecutive code block merges together: www.phabricator.com/docs/javelin/article/Concepts_Event_Delegation.html
    
    Test Plan: Generated docs.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3359
    vrana committed Aug 22, 2012
  2. Support synchronous requests

    Summary:
    It is needed in the `unload` handler.
    Maybe we can rename it to `blockBrowserUIUntilTheRequestFinishes`.
    
    Test Plan: Used in D3356.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3358
    vrana committed Aug 21, 2012
Commits on Aug 13, 2012
  1. Add getDatasource function for typeahead

    Summary:
    Sometimes we need to access the datasource of typeahead, rather
    than accessing using typeahead._datasource, should we just make a
    getDatasource() function?
    
    Test Plan: test getting the datasource using getDatasource()
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3260
    Hendri - committed Aug 13, 2012
Commits on Aug 10, 2012
  1. Merge pull request #29 from lifeinafolder/master

    Typo in last pull request
    epriestley committed Aug 10, 2012
  2. Merge pull request #28 from lifeinafolder/master

    Use JX.isArray instead of instanceOf
    epriestley committed Aug 10, 2012
Commits on Aug 8, 2012
  1. Fix JavaScript syntax error

    vrana committed Aug 8, 2012
Commits on Aug 7, 2012
  1. Rebuild premade Javelin packages

    Summary:
    We include some premade Javelin packages that haven't been rebuild recently. Rebuild them.
    
    This diff was created by running `scripts/rebuild-packages.php`.
    
    Test Plan: Scripted rebuild. Examples work.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3163
    epriestley committed Aug 7, 2012
  2. Add an example of complex tokenizer behavior

    Summary: See D3143. Depends on D3159, D3160, D3161.
    
    Test Plan: Used example.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3162
    epriestley committed Aug 7, 2012
  3. Add a getResult(id) method to TypeaheadSource

    Summary:
    In some places, like the `choose` event of JX.Typeahead and the `getTokens()` method of JX.Tokenizer, we return result IDs and some piece of derived data (the node in the former case, the display string in the latter case). In most cases, these are sufficient, if somewhat awkward and possibly poor architectural decisions.
    
    However, sometimes we need the raw result with any additional data it may carry (see D3143). Add a method to do a lookup by ID.
    
    Test Plan: Built an example using this, see D3143.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3161
    epriestley committed Aug 7, 2012
  4. Add JX.TypeaheadStaticSource

    Summary: Add a completely static source to compliment the existing Ajax sources (preloaded / ondemand), useful for small data or examples.
    
    Test Plan: Built a simple example using this source, see D3143.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3160
    epriestley committed Aug 7, 2012
  5. Fix an issue where the the internal state of a Typeahead was not prop…

    …erly cleared after a token was selected
    
    Summary:
    JX.Typeahead keeps a copy of the input state so we can discard keypresses which don't change the input, but we were manually clearing the input rather than calling clear() properly. Additionally, we don't clear the internal state in clear().
    
    Instead, call clear() from JX.Tokenizer, and reset the internal state in clear().
    
    A specific way to trigger this bug is type "z" in a Tokenizer (assuming it matches 2+ tokens), get a match, hit return to select it, and then type "z" again. The incorrect behavior (before this patch) was for the typeahead suggestion list to remain hidden until you typed another character. The correct behavior (after this patch) is for the suggestion list to reopen.
    
    Test Plan: Typed "z", selected a token, typed "z", got a suggestion list.
    
    Reviewers: hendri
    
    Reviewed By: hendri
    
    CC: jeffmo, linjeffrey, aran
    
    Differential Revision: https://secure.phabricator.com/D3159
    epriestley committed Aug 7, 2012
Commits on Aug 2, 2012
  1. Reload less aggressively in URI.go

    Summary:
    Firefox (and maybe also other browsers) does ignore-the-cache reload (Ctrl+F5) on `window.location.reload`.
    Replace this by assignment to `window.location`.
    We can't use `window.location = window.location` because it does nothing if there is a hash.
    
    Test Plan: Flagged a revision, checked the files transfered.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D3135
    vrana committed Aug 2, 2012
Commits on Jul 31, 2012
  1. Fix TypeaheadSource not considering excludeids

    Summary:
    Previously, TypeaheadSource doesn't consider the excludeids
    that are updated after the datasource has been created. It should also
    check for it every time the match results is called so that it supports adding/removing exclude ids on lookup time.
    
    Test Plan:
    Try to insert an exclude id via javascript after datasource
    has been initialized. Type in the name, make sure the name is now not included in the typeahead
    
    Reviewers: linjeffrey, jeffmo, epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley
    
    Differential Revision: https://secure.phabricator.com/D3108
    Hendri - committed Jul 31, 2012
Commits on Jul 25, 2012
  1. Merge pull request #27 from tonycoco/patch-1

    Updating to HTML5 for data-attributes.
    epriestley committed Jul 25, 2012
Commits on Jul 18, 2012
  1. Fix a typo (thanks @andreys!).

    epriestley committed Jul 18, 2012
Commits on Jul 11, 2012
  1. Improve error handling in javelin lib - Resource.js (fail to download)

    Summary: See title
    
    Test Plan:
    1. Basic tests to verify onscuccess is executed correctly
    2. Simulating download failures
    
    Reviewers: jeffmo, epriestley
    
    Reviewed By: epriestley
    
    CC: aran, epriestley, cpojer
    
    Differential Revision: https://secure.phabricator.com/D2960
    Marek Latuskiewicz committed Jul 11, 2012
Commits on Jun 15, 2012
  1. Typeahead control stops responding after item tapped - Mobile Safari

    Summary:
    Mobile Safari has a strange bug. When the Typeahead control is rendered
    within an iframe, once one of the typeahead items is tapped, the input
    box stops accepting keypresses. (New characters, as well as keys like
    backspace, are ignored). This also affects the Tokenizer control, in
    that once one token is chosen, the user cannot type additional tokens.
    
    This seems to be caused by calling e.prevent() within the Mousedown
    event of the typeahead items, though it's unclear why. Removing that
    line doesn't seem to cause any negative effects - the items lose focus
    and are hidden as part of the mousedown.
    
    I also included a fix for a 2nd bug that blocked testing this fix:
    the placeholder code currently clears the typeahead contents when it
    loses focus, which can result in the loss of user input.
    
    Test Plan:
     1. View typeahead control, rendered within an iframe, on mobile safari.
     2. Begin typing, and tap one of the suggestions.
    
    Reviewers: yungsters, jg, epriestley
    
    Reviewed By: epriestley
    
    CC: phunt, aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D2762
    Dave Alongi committed Jun 12, 2012
Commits on Jun 13, 2012
  1. Merge pull request #19 from yliang6/master

    Add CORS support and non-JSON response support to JX.Request
    epriestley committed Jun 13, 2012
  2. Add CORS support and non-JSON response support to JX.Request

    Summary:
     CORS
    - supports XHR w/ withCredentials and XDomainRequest as transport
    - added a flag 'CORS' to toggle this
    
    non-JSON response
    - added a property responseType to allow 'JSON', 'TEXT' and 'XML' as the response type
    - added a responseHandler property to handle response of non-JSON format
    
    Test Plan:
    1. rebuild packages;
    2. go to sandbox page that loads javelin;
    3. test request in chrome javascript console:
    
      window['call_result'] = '';
      var req = new JX.Request('http://bango.net/idxml/?bango=12345').setCORS(true).setMethod('GET').setExpectCSRFGuard(false).setResponseType('XML').setResponseHandler(function(resp){window.call_result = resp;});
      req.send();
    
    4. verified the request was sucessful and the result is expected.
    
    Reviewers: jeffmo, vrana, epriestley, aran, leebyron, erling
    
    Reviewed By: epriestley
    
    CC: Korvin
    
    Differential Revision: https://secure.phabricator.com/D2697
    Ying-Yi Liang committed Jun 13, 2012
Commits on Jun 12, 2012
  1. Merge pull request #17 from lifeinafolder/optimization

    Optimizing JX.Keys with native Object.Keys if available
    epriestley committed Jun 12, 2012