Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[javelinsymbols] -- Add support to javelinsymbols for JX.behavior() #15

Merged
merged 1 commit into from Mar 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

jeffmo commented Mar 26, 2012

Summary:
Currently javelinsymbols can detect the installation of a class...but not behaviors. This adds support to the javelinsymbols processor to identify behavior-registrations and specify them using a new '*' directive.

I plan to use javelinsymbols for a project to implicitly identify a unique name for a given JS resource based on the JX.install()s and JX.behavior()s calls that exist in the file.

Test Plan: Compiled and ran javlinesymbols against a file with a JX.install(), a file with JX.behavior(), and a file with both to verify the output was as expected.

Reviewers: leebyron, epriestley, jg

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2023

@jeffmo jeffmo [javelinsymbols] -- Add support to javelinsymbols for JX.behavior()
Summary:
Currently javelinsymbols can detect the installation of a class...but not behaviors. This adds support to the javelinsymbols processor to identify behavior-registrations and specify them using a new '*' directive.

I plan to use javelinsymbols for a project to implicitly identify a unique name for a given JS resource based on the JX.install()s and JX.behavior()s calls that exist in the file.

Test Plan: Compiled and ran javlinesymbols against a file with a JX.install(), a file with JX.behavior(), and a file with both to verify the output was as expected.

Reviewers: leebyron, epriestley, jg

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2023
469619c

@epriestley epriestley added a commit that referenced this pull request Mar 26, 2012

@epriestley epriestley Merge pull request #15 from jeffmo/javelinsymbols_behavior_support
[javelinsymbols] -- Add support to javelinsymbols for JX.behavior()
005ca26

@epriestley epriestley merged commit 005ca26 into phacility:master Mar 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment