Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Optimizing JX.Keys with native Object.Keys if available #17

Merged
merged 1 commit into from Jun 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

lifeinafolder commented Jun 12, 2012

Defaulting to Object.Keys for JX.Keys if its available.

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/keys

Also, JX.Keys should typically only return enumerable keys. Currently, usage of for-in causes it to enumerate prototype chain properties too.

epriestley added a commit that referenced this pull request Jun 12, 2012

Merge pull request #17 from lifeinafolder/optimization
Optimizing JX.Keys with native Object.Keys if available

@epriestley epriestley merged commit 2e900a1 into phacility:master Jun 12, 2012

Owner

epriestley commented Jun 12, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment