Recent updates to Javelin #7

Merged
merged 6 commits into from Jun 23, 2011

Projects

None yet

2 participants

@cpojer
Contributor
cpojer commented Jun 23, 2011

Pull 'em.

cpojer added some commits Jun 20, 2011
@cpojer cpojer Minor code cleanup in behavior.js
Summary: Removed some unnecessary code blocks.

Reviewers: tomo, epriestley

Test Plan: Ensure that JX.behavior still works

Differential Revision: 486
fa86e72
@cpojer cpojer Add Jasmine Unit Test Library
Summary: This adds the Jasmine Unit Test Library for the Javelin unit
tests.

Test Plan: Open specs/ and see All (0) specs pass.

Reviewers: tomo, epriestley

CC:

Differential Revision: 487
58f5e6b
@cpojer cpojer Add some Specs for Javelin
Summary: This adds some Specs for Javelin ready to be run through
Jasmine.
Note: Port back the dataPersistence Stratcom test to fbcode
(ensure__DEV__)

Test Plan: Open specs/ in your browser and see the specs pass

Reviewers: tomo, epriestley

CC:

Differential Revision: 488
7893a9c
@cpojer cpojer Add JX.log in non-dev mode to prevent silent fails
Summary: JX.log is part of the public API (it is listed in the @requires
block in util.js). In non-dev mode this method gets stripped out and
could potentially cause errors that the developer overlooked. Adding
JX.log as an empty function in non-dev mode.

Test Plan: Ensure the JX.log is available if __DEV__ is false.

Reviewers: tomo, epriestley

CC:

Differential Revision: 492
4e1ea5e
@cpojer cpojer Add JX.isArray for reliable array type checks
Summary: instanceof Array is not reliable in cases where Arrays might
come from other contexts. Use the ES5 method Array.isArray or
Object.prototype.toString instead.

Test Plan: Check the included specs

Reviewers: tomo, epriestley

CC:

Differential Revision: 493
fdb8b03
@cpojer cpojer Minor code cleanups (= less code)
Summary: Some minor cleanups, nothing serious. Some variables were
defined more than once in the same scope.

Test Plan: Run the specs / examples

Reviewers: tomo, epriestley

CC:

Differential Revision: 494
3274931
@epriestley epriestley merged commit d801a29 into phacility:master Jun 23, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment