Permalink
Browse files

Notications mobile menu

Summary: Adding CSS so the notifications menu renders over content on mobile, also it was sort of broken at some point.

Test Plan: Tested Mobile, Tablet and regular layouts.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5424
  • Loading branch information...
1 parent 4c57f8a commit 004a8de35067030e8bd7654e01898313d7ff0917 @chadlittle chadlittle committed Mar 22, 2013
Showing with 54 additions and 46 deletions.
  1. +39 −39 src/__celerity_resource_map__.php
  2. +15 −7 webroot/rsrc/css/application/base/notification-menu.css
@@ -2979,7 +2979,7 @@
),
'phabricator-notification-menu-css' =>
array(
- 'uri' => '/res/b7cc25af/rsrc/css/application/base/notification-menu.css',
+ 'uri' => '/res/bc245b67/rsrc/css/application/base/notification-menu.css',
'type' => 'css',
'requires' =>
array(
@@ -3686,7 +3686,7 @@
), array(
'packages' =>
array(
- 'ebd26861' =>
+ '3f552ecc' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@@ -3728,7 +3728,7 @@
34 => 'phabricator-object-item-list-view-css',
35 => 'global-drag-and-drop-css',
),
- 'uri' => '/res/pkg/ebd26861/core.pkg.css',
+ 'uri' => '/res/pkg/3f552ecc/core.pkg.css',
'type' => 'css',
),
'95ceba95' =>
@@ -3919,16 +3919,16 @@
'reverse' =>
array(
'aphront-attached-file-view-css' => 'c41b4907',
- 'aphront-dialog-view-css' => 'ebd26861',
- 'aphront-error-view-css' => 'ebd26861',
- 'aphront-form-view-css' => 'ebd26861',
- 'aphront-list-filter-view-css' => 'ebd26861',
- 'aphront-pager-view-css' => 'ebd26861',
- 'aphront-panel-view-css' => 'ebd26861',
- 'aphront-table-view-css' => 'ebd26861',
- 'aphront-tokenizer-control-css' => 'ebd26861',
- 'aphront-tooltip-css' => 'ebd26861',
- 'aphront-typeahead-control-css' => 'ebd26861',
+ 'aphront-dialog-view-css' => '3f552ecc',
+ 'aphront-error-view-css' => '3f552ecc',
+ 'aphront-form-view-css' => '3f552ecc',
+ 'aphront-list-filter-view-css' => '3f552ecc',
+ 'aphront-pager-view-css' => '3f552ecc',
+ 'aphront-panel-view-css' => '3f552ecc',
+ 'aphront-table-view-css' => '3f552ecc',
+ 'aphront-tokenizer-control-css' => '3f552ecc',
+ 'aphront-tooltip-css' => '3f552ecc',
+ 'aphront-typeahead-control-css' => '3f552ecc',
'differential-changeset-view-css' => '8aaacd1b',
'differential-core-view-css' => '8aaacd1b',
'differential-inline-comment-editor' => '322728f3',
@@ -3942,7 +3942,7 @@
'differential-table-of-contents-css' => '8aaacd1b',
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
- 'global-drag-and-drop-css' => 'ebd26861',
+ 'global-drag-and-drop-css' => '3f552ecc',
'inline-comment-summary-css' => '8aaacd1b',
'javelin-aphlict' => '95ceba95',
'javelin-behavior' => 'fe22443b',
@@ -4014,48 +4014,48 @@
'javelin-util' => 'fe22443b',
'javelin-vector' => 'fe22443b',
'javelin-workflow' => 'fe22443b',
- 'lightbox-attachment-css' => 'ebd26861',
+ 'lightbox-attachment-css' => '3f552ecc',
'maniphest-task-summary-css' => 'c41b4907',
'maniphest-transaction-detail-css' => 'c41b4907',
'phabricator-busy' => '95ceba95',
'phabricator-content-source-view-css' => '8aaacd1b',
- 'phabricator-core-buttons-css' => 'ebd26861',
- 'phabricator-core-css' => 'ebd26861',
- 'phabricator-crumbs-view-css' => 'ebd26861',
- 'phabricator-directory-css' => 'ebd26861',
+ 'phabricator-core-buttons-css' => '3f552ecc',
+ 'phabricator-core-css' => '3f552ecc',
+ 'phabricator-crumbs-view-css' => '3f552ecc',
+ 'phabricator-directory-css' => '3f552ecc',
'phabricator-drag-and-drop-file-upload' => '322728f3',
'phabricator-dropdown-menu' => '95ceba95',
'phabricator-file-upload' => '95ceba95',
- 'phabricator-filetree-view-css' => 'ebd26861',
- 'phabricator-flag-css' => 'ebd26861',
- 'phabricator-form-view-css' => 'ebd26861',
- 'phabricator-header-view-css' => 'ebd26861',
- 'phabricator-jump-nav' => 'ebd26861',
+ 'phabricator-filetree-view-css' => '3f552ecc',
+ 'phabricator-flag-css' => '3f552ecc',
+ 'phabricator-form-view-css' => '3f552ecc',
+ 'phabricator-header-view-css' => '3f552ecc',
+ 'phabricator-jump-nav' => '3f552ecc',
'phabricator-keyboard-shortcut' => '95ceba95',
'phabricator-keyboard-shortcut-manager' => '95ceba95',
- 'phabricator-main-menu-view' => 'ebd26861',
+ 'phabricator-main-menu-view' => '3f552ecc',
'phabricator-menu-item' => '95ceba95',
- 'phabricator-nav-view-css' => 'ebd26861',
+ 'phabricator-nav-view-css' => '3f552ecc',
'phabricator-notification' => '95ceba95',
- 'phabricator-notification-css' => 'ebd26861',
- 'phabricator-notification-menu-css' => 'ebd26861',
- 'phabricator-object-item-list-view-css' => 'ebd26861',
+ 'phabricator-notification-css' => '3f552ecc',
+ 'phabricator-notification-menu-css' => '3f552ecc',
+ 'phabricator-object-item-list-view-css' => '3f552ecc',
'phabricator-object-selector-css' => '8aaacd1b',
'phabricator-paste-file-upload' => '95ceba95',
'phabricator-prefab' => '95ceba95',
'phabricator-project-tag-css' => 'c41b4907',
- 'phabricator-remarkup-css' => 'ebd26861',
+ 'phabricator-remarkup-css' => '3f552ecc',
'phabricator-shaped-request' => '322728f3',
- 'phabricator-side-menu-view-css' => 'ebd26861',
- 'phabricator-standard-page-view' => 'ebd26861',
+ 'phabricator-side-menu-view-css' => '3f552ecc',
+ 'phabricator-standard-page-view' => '3f552ecc',
'phabricator-textareautils' => '95ceba95',
'phabricator-tooltip' => '95ceba95',
- 'phabricator-transaction-view-css' => 'ebd26861',
- 'phabricator-zindex-css' => 'ebd26861',
- 'sprite-apps-large-css' => 'ebd26861',
- 'sprite-gradient-css' => 'ebd26861',
- 'sprite-icon-css' => 'ebd26861',
- 'sprite-menu-css' => 'ebd26861',
- 'syntax-highlighting-css' => 'ebd26861',
+ 'phabricator-transaction-view-css' => '3f552ecc',
+ 'phabricator-zindex-css' => '3f552ecc',
+ 'sprite-apps-large-css' => '3f552ecc',
+ 'sprite-gradient-css' => '3f552ecc',
+ 'sprite-icon-css' => '3f552ecc',
+ 'sprite-menu-css' => '3f552ecc',
+ 'syntax-highlighting-css' => '3f552ecc',
),
));
@@ -7,6 +7,10 @@
font-size: 11px;
word-wrap: break-word;
overflow-y: auto;
+ box-shadow: 0px 2px 6px rgba(0, 0, 0, 0.5);
+ border: 2px solid #33393d;
+ border-top-width: 0;
+ border-radius: 3px;
}
.phabricator-notification-menu-loading {
@@ -15,19 +19,21 @@
color: #888888;
}
-.device-desktop .phabricator-notification-menu {
+.device-desktop .phabricator-notification-menu,
+.device-tablet .phabricator-notification-menu {
position: fixed;
width: 360px;
top: 42px;
- box-shadow: 0px 2px 6px rgba(0, 0, 0, 0.5);
-
- border: 2px solid #33393d;
- border-top-width: 0;
- border-radius: 3px;
}
-.device .phabricator-notification-menu {
+.device-phone .phabricator-notification-menu {
border-bottom: 1px solid #222222;
+ width: 94%;
+ max-width: 390px;
+ top: 42px !important;
+ left: 3% !important;
+ position: absolute;
+
}
.phabricator-notification {
@@ -68,5 +74,7 @@
font-weight: bold;
background: #f7f7f7;
border-top: 1px solid #e9e9e9;
+ border-bottom-left-radius: 3px;
+ border-bottom-right-radius: 3px;
padding: 6px;
}

0 comments on commit 004a8de

Please sign in to comment.