Browse files

Remove support for custom logos

Summary:
  - These don't fit anywhere in the new design.
  - Even if we figure out how to fit them in, 220px logos definitely won't fit on the 320px iPhone screen so anyone who has a custom logo will have to rework them anyway.
  - Kill it for now, and once we get the new design in and working maybe we can restore it somehow.

Test Plan: Loaded local install, no logo. Grepped for config.

Reviewers: btrahan, vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1569

Differential Revision: https://secure.phabricator.com/D3101
  • Loading branch information...
1 parent 9fd2b37 commit 0cc3cb75597e3624c4ab5113131443e8097173f6 @epriestley epriestley committed Jul 30, 2012
View
3 .gitignore
@@ -15,6 +15,3 @@
# Arcanist scratch directory
/.arc
-
-# Custom Logo File
-/webroot/rsrc/image/custom/custom.png
View
9 conf/default.conf.php
@@ -56,15 +56,6 @@
'security.hmac-key' => '[D\t~Y7eNmnQGJ;rnH6aF;m2!vJ8@v8C=Cs:aQS\.Qw',
-// -- Customization --------------------------------------------------------- //
-
- // If you want to use a custom logo (e.g., for your company or organization),
- // copy 'webroot/rsrc/image/custom/example_template.png' to
- // 'webroot/rsrc/image/custom/custom.png' and set this to the URI you want it
- // to link to (like http://www.yourcompany.com/).
- 'phabricator.custom.logo' => null,
-
-
// -- Internationalization -------------------------------------------------- //
// This allows customizing texts used in Phabricator. The class must extend
View
17 src/view/page/PhabricatorStandardPageView.php
@@ -381,20 +381,6 @@ protected function getBody() {
$admin_class = 'phabricator-admin-page-view';
}
- $custom_logo = null;
- $with_custom = null;
- $custom_conf = PhabricatorEnv::getEnvConfig('phabricator.custom.logo');
- if ($custom_conf) {
- $with_custom = 'phabricator-logo-with-custom';
- $custom_logo = phutil_render_tag(
- 'a',
- array(
- 'class' => 'logo-custom',
- 'href' => $custom_conf,
- ),
- ' ');
- }
-
$notification_indicator = '';
$notification_dropdown = '';
$notification_container = '';
@@ -481,8 +467,7 @@ protected function getBody() {
$header_chrome =
'<table class="phabricator-standard-header">'.
'<tr>'.
- '<td class="phabricator-logo '.$with_custom.'">'.
- $custom_logo.
+ '<td class="phabricator-logo">'.
'<a class="logo-standard" href="/"> </a>'.
'</td>'.
$notification_indicator.
View
18 webroot/rsrc/css/application/base/standard-page-view.css
@@ -53,10 +53,6 @@
width: 220px;
}
-.phabricator-logo-with-custom {
- width: 440px;
-}
-
.phabricator-logo a {
display: block;
width: 220px;
@@ -65,10 +61,6 @@
margin: 0;
}
-.phabricator-logo a.logo-custom {
- position: absolute;
- background: url(/rsrc/image/custom/custom.png) no-repeat 0 0;
-}
.phabricator-logo a.logo-standard {
background: url(/rsrc/image/phabricator_logo.png) no-repeat -220px 0;
@@ -78,20 +70,10 @@
background-image: url(/rsrc/image/phabricator_logo_admin.png);
}
-.phabricator-logo-with-custom a.logo-standard {
- padding-left: 220px;
- background-position: 0 0;
-}
-
.phabricator-logo a.logo-standard:hover {
background-position: -220px -40px;
}
-.phabricator-logo a.logo-custom:hover,
-.phabricator-logo-with-custom a.logo-standard:hover {
- background-position: 0 -40px;
-}
-
.phabricator-primary-navigation td {
padding-left: 10px;
padding-right: 10px;
View
3 webroot/rsrc/image/custom/README
@@ -1,3 +0,0 @@
-To customize your Phabricator install's appearance, create a 220x80 PNG like
-the examples in this folder, name it "custom.png" in this folder, and then set
-'phabricator.custom.logo' to a link URI.
View
BIN webroot/rsrc/image/custom/example_facebook.png
Deleted file not rendered
View
BIN webroot/rsrc/image/custom/example_rainbow.png
Deleted file not rendered
View
BIN webroot/rsrc/image/custom/example_template.png
Deleted file not rendered

0 comments on commit 0cc3cb7

Please sign in to comment.