Browse files

add code to drop old databases

Summary: these existed once, are no more, and don't get cleaned up in the current code path

Test Plan: storage destroy --dryrun -- noted the correct database names

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2237

Differential Revision:
  • Loading branch information...
1 parent 7b2ab1a commit 2f6104bf8bd38a358dadf1a429d5e7ff666c3348 @bobtrahan bobtrahan committed Jan 3, 2013
@@ -53,6 +53,9 @@ public function execute(PhutilArgumentParser $args) {
} else {
$databases = $api->getDatabaseList($patches);
$databases[] = $api->getDatabaseName('meta_data');
+ // These are legacy databases that were dropped long ago. See T2237.
+ $databases[] = $api->getDatabaseName('phid');
+ $databases[] = $api->getDatabaseName('directory');
foreach ($databases as $database) {

0 comments on commit 2f6104b

Please sign in to comment.