Browse files

Some pht()'s for People that got missed

Summary: We certainly don't go all-caps enough, else we would have noticed them.

Test Plan: Looked at profiles, people edit page before and after with All-Caps

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5450
  • Loading branch information...
1 parent e246001 commit 5320d85343e7d7a8b54e665ae0c66c281181e74d @AnhNhan AnhNhan committed with epriestley Mar 26, 2013
View
2 src/applications/people/controller/PhabricatorPeopleEditController.php
@@ -334,7 +334,7 @@ private function processBasicRequest(PhabricatorUser $user) {
$form->appendChild(
id(new AphrontFormStaticControl())
- ->setLabel('Roles')
+ ->setLabel(pht('Roles'))
->setValue($roles));
}
View
20 src/applications/people/controller/PhabricatorPeopleProfileController.php
@@ -131,7 +131,7 @@ public function processRequest() {
->setDescription($profile->getTitle());
if ($user->getIsDisabled()) {
- $header->setStatus('Disabled');
+ $header->setStatus(pht('Disabled'));
} else {
$statuses = id(new PhabricatorUserStatus())->loadCurrentStatuses(
array($user->getPHID()));
@@ -180,33 +180,38 @@ private function renderBasicInformation($user, $profile) {
$content = hsprintf(
'<div class="phabricator-profile-info-group">
- <h1 class="phabricator-profile-info-header">Basic Information</h1>
+ <h1 class="phabricator-profile-info-header">%s</h1>
<div class="phabricator-profile-info-pane">
<table class="phabricator-profile-info-table">
<tr>
- <th>PHID</th>
+ <th>%s</th>
<td>%s</td>
</tr>
<tr>
- <th>User Since</th>
+ <th>%s</th>
<td>%s</td>
</tr>
</table>
</div>
</div>'.
'<div class="phabricator-profile-info-group">
- <h1 class="phabricator-profile-info-header">Flavor Text</h1>
+ <h1 class="phabricator-profile-info-header">%s</h1>
<div class="phabricator-profile-info-pane">
<table class="phabricator-profile-info-table">
<tr>
- <th>Blurb</th>
+ <th>%s</th>
<td>%s</td>
</tr>
</table>
</div>
</div>',
+ pht('Basic Information'),
+ pht('PHID'),
$user->getPHID(),
+ pht('User Since'),
phabricator_datetime($user->getDateCreated(), $viewer),
+ pht('Flavor Text'),
+ pht('Blurb'),
$blurb);
return $content;
@@ -230,9 +235,10 @@ private function renderUserFeed(PhabricatorUser $user) {
return hsprintf(
'<div class="phabricator-profile-info-group">
- <h1 class="phabricator-profile-info-header">Activity Feed</h1>
+ <h1 class="phabricator-profile-info-header">%s</h1>
<div class="phabricator-profile-info-pane">%s</div>
</div>',
+ pht('Activity Feed'),
$view->render());
}
}

0 comments on commit 5320d85

Please sign in to comment.