Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Delete maniphest.enabled and phriction.enabled
Summary: @edward, you would need to delete these options from FB config to avoid setup warning.

Test Plan: /T1

Reviewers: epriestley, edward

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5620
  • Loading branch information
vrana committed Apr 9, 2013
1 parent 9da6c9f commit c621da8
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 33 deletions.
8 changes: 0 additions & 8 deletions conf/default.conf.php
Expand Up @@ -1083,9 +1083,6 @@

// -- Maniphest ------------------------------------------------------------- //

// Deprecated, use 'phabricator.uninstalled-applications' instead.
'maniphest.enabled' => true,

// Array of custom fields for Maniphest tasks. For details on adding custom
// fields to Maniphest, see "Maniphest User Guide: Adding Custom Fields".
'maniphest.custom-fields' => array(),
Expand All @@ -1099,11 +1096,6 @@
// Defaults to "needs triage".
'maniphest.default-priority' => 90,

// -- Phriction ------------------------------------------------------------- //

// Deprecated, use 'phabricator.uninstalled-applications' instead.
'phriction.enabled' => true,

// -- Phame ----------------------------------------------------------------- //

// Should Phame users have Disqus comment widget, and if so what's the
Expand Down
Expand Up @@ -10,13 +10,6 @@ public function getBaseURI() {
return '/maniphest/';
}

public function isInstalled() {
if (!PhabricatorEnv::getEnvConfig('maniphest.enabled')) {
return false;
}
return parent::isInstalled();
}

public function getIconName() {
return 'maniphest';
}
Expand Down
Expand Up @@ -13,9 +13,6 @@ public function getDescription() {

public function getOptions() {
return array(
$this->newOption('maniphest.enabled', 'bool', true)
->setDescription(pht(
"Deprecated, use 'phabricator.uninstalled-applications' instead.")),
$this->newOption('maniphest.custom-fields', 'wild', array())
->setSummary(pht("Custom Maniphest fields."))
->setDescription(
Expand Down
Expand Up @@ -18,13 +18,6 @@ public function getHelpURI() {
return PhabricatorEnv::getDoclink('article/Phriction_User_Guide.html');
}

public function isInstalled() {
if (!PhabricatorEnv::getEnvConfig('phriction.enabled')) {
return false;
}
return parent::isInstalled();
}

public function getTitleGlyph() {
return "\xE2\x9A\xA1";
}
Expand Down
Expand Up @@ -13,14 +13,6 @@ public function getDescription() {

public function getOptions() {
return array(
$this->newOption('phriction.enabled', 'bool', true)
->setBoolOptions(
array(
pht("Enable Phriction"),
pht("Disable Phriction"),
))
->setDescription(pht(
"Deprecated, use 'phabricator.uninstalled-applications' instead.")),
$this->newOption(
'metamta.phriction.subject-prefix', 'string', '[Phriction]')
->setDescription(pht("Subject prefix for Phriction email.")),
Expand Down

4 comments on commit c621da8

@edward
Copy link

@edward edward commented on c621da8 Apr 9, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epriestley
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "@edward" in this commit message is an @edward in a different system. I'm not sure if there's a way for you to block notifications when commits mentioning him are pushed here or not. Sorry. :/

@edward
Copy link

@edward edward commented on c621da8 Apr 9, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardspeyer
Copy link
Contributor

@edwardspeyer edwardspeyer commented on c621da8 Apr 9, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.