Permalink
Browse files

Fix title for phabricator home page

Summary:
My browser was showing the url of phabricator as the title instead of the real
title. Fix it so the title set for the home page actually gets used.

Test Plan: load phabricator and see "Bacon Ice Cream for Breakfast" as the title

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, chad

Differential Revision: https://secure.phabricator.com/D5428
  • Loading branch information...
1 parent 42e875e commit d2b7bb950440d80c76ab9ed83b85b4a63213ca8f Nick Harper committed Mar 26, 2013
@@ -148,9 +148,9 @@ public function buildApplicationPage($view, array $options) {
$page = $this->buildStandardPageView();
$application = $this->getCurrentApplication();
+ $page->setTitle(idx($options, 'title'));
if ($application) {
$page->setApplicationName($application->getName());
- $page->setTitle(idx($options, 'title'));
if ($application->getTitleGlyph()) {
$page->setGlyph($application->getTitleGlyph());
}
@@ -65,10 +65,14 @@ private function buildMainResponse($nav, array $projects) {
$nav->appendChild($content);
$nav->appendChild(new PhabricatorGlobalUploadTargetView());
+ $title = PhabricatorEnv::getEnvConfig('phabricator.serious-business') ?
+ 'Phabricator' :
+ pht('Bacon Ice Cream for Breakfast');
+
return $this->buildApplicationPage(
$nav,
array(
- 'title' => 'Phabricator',
+ 'title' => $title,
'device' => true,
));
}

0 comments on commit d2b7bb9

Please sign in to comment.