Permalink
Browse files

Separate object names from object links in other applications

Summary: Move `Fnn`, `Pnn`, etc., out of the link text so they can be double-clicked to select.

Test Plan: Viewed Paste, Files, Ponder.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5433
  • Loading branch information...
1 parent 8696b8c commit dcfe011fc78f4a364ad390e718e0e89a8bc28940 @epriestley epriestley committed Mar 23, 2013
View
78 src/__celerity_resource_map__.php
@@ -2996,7 +2996,7 @@
),
'phabricator-object-item-list-view-css' =>
array(
- 'uri' => '/res/f5dcfaf4/rsrc/css/layout/phabricator-object-item-list-view.css',
+ 'uri' => '/res/527ed374/rsrc/css/layout/phabricator-object-item-list-view.css',
'type' => 'css',
'requires' =>
array(
@@ -3694,7 +3694,7 @@
), array(
'packages' =>
array(
- '5515b5b4' =>
+ '2f159460' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@@ -3736,7 +3736,7 @@
34 => 'phabricator-object-item-list-view-css',
35 => 'global-drag-and-drop-css',
),
- 'uri' => '/res/pkg/5515b5b4/core.pkg.css',
+ 'uri' => '/res/pkg/2f159460/core.pkg.css',
'type' => 'css',
),
'95ceba95' =>
@@ -3927,16 +3927,16 @@
'reverse' =>
array(
'aphront-attached-file-view-css' => '6b1fccc6',
- 'aphront-dialog-view-css' => '5515b5b4',
- 'aphront-error-view-css' => '5515b5b4',
- 'aphront-form-view-css' => '5515b5b4',
- 'aphront-list-filter-view-css' => '5515b5b4',
- 'aphront-pager-view-css' => '5515b5b4',
- 'aphront-panel-view-css' => '5515b5b4',
- 'aphront-table-view-css' => '5515b5b4',
- 'aphront-tokenizer-control-css' => '5515b5b4',
- 'aphront-tooltip-css' => '5515b5b4',
- 'aphront-typeahead-control-css' => '5515b5b4',
+ 'aphront-dialog-view-css' => '2f159460',
+ 'aphront-error-view-css' => '2f159460',
+ 'aphront-form-view-css' => '2f159460',
+ 'aphront-list-filter-view-css' => '2f159460',
+ 'aphront-pager-view-css' => '2f159460',
+ 'aphront-panel-view-css' => '2f159460',
+ 'aphront-table-view-css' => '2f159460',
+ 'aphront-tokenizer-control-css' => '2f159460',
+ 'aphront-tooltip-css' => '2f159460',
+ 'aphront-typeahead-control-css' => '2f159460',
'differential-changeset-view-css' => '8aaacd1b',
'differential-core-view-css' => '8aaacd1b',
'differential-inline-comment-editor' => '322728f3',
@@ -3950,7 +3950,7 @@
'differential-table-of-contents-css' => '8aaacd1b',
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
- 'global-drag-and-drop-css' => '5515b5b4',
+ 'global-drag-and-drop-css' => '2f159460',
'inline-comment-summary-css' => '8aaacd1b',
'javelin-aphlict' => '95ceba95',
'javelin-behavior' => 'fe22443b',
@@ -4022,48 +4022,48 @@
'javelin-util' => 'fe22443b',
'javelin-vector' => 'fe22443b',
'javelin-workflow' => 'fe22443b',
- 'lightbox-attachment-css' => '5515b5b4',
+ 'lightbox-attachment-css' => '2f159460',
'maniphest-task-summary-css' => '6b1fccc6',
'maniphest-transaction-detail-css' => '6b1fccc6',
'phabricator-busy' => '95ceba95',
'phabricator-content-source-view-css' => '8aaacd1b',
- 'phabricator-core-buttons-css' => '5515b5b4',
- 'phabricator-core-css' => '5515b5b4',
- 'phabricator-crumbs-view-css' => '5515b5b4',
- 'phabricator-directory-css' => '5515b5b4',
+ 'phabricator-core-buttons-css' => '2f159460',
+ 'phabricator-core-css' => '2f159460',
+ 'phabricator-crumbs-view-css' => '2f159460',
+ 'phabricator-directory-css' => '2f159460',
'phabricator-drag-and-drop-file-upload' => '322728f3',
'phabricator-dropdown-menu' => '95ceba95',
'phabricator-file-upload' => '95ceba95',
- 'phabricator-filetree-view-css' => '5515b5b4',
- 'phabricator-flag-css' => '5515b5b4',
- 'phabricator-form-view-css' => '5515b5b4',
- 'phabricator-header-view-css' => '5515b5b4',
- 'phabricator-jump-nav' => '5515b5b4',
+ 'phabricator-filetree-view-css' => '2f159460',
+ 'phabricator-flag-css' => '2f159460',
+ 'phabricator-form-view-css' => '2f159460',
+ 'phabricator-header-view-css' => '2f159460',
+ 'phabricator-jump-nav' => '2f159460',
'phabricator-keyboard-shortcut' => '95ceba95',
'phabricator-keyboard-shortcut-manager' => '95ceba95',
- 'phabricator-main-menu-view' => '5515b5b4',
+ 'phabricator-main-menu-view' => '2f159460',
'phabricator-menu-item' => '95ceba95',
- 'phabricator-nav-view-css' => '5515b5b4',
+ 'phabricator-nav-view-css' => '2f159460',
'phabricator-notification' => '95ceba95',
- 'phabricator-notification-css' => '5515b5b4',
- 'phabricator-notification-menu-css' => '5515b5b4',
- 'phabricator-object-item-list-view-css' => '5515b5b4',
+ 'phabricator-notification-css' => '2f159460',
+ 'phabricator-notification-menu-css' => '2f159460',
+ 'phabricator-object-item-list-view-css' => '2f159460',
'phabricator-object-selector-css' => '8aaacd1b',
'phabricator-paste-file-upload' => '95ceba95',
'phabricator-prefab' => '95ceba95',
'phabricator-project-tag-css' => '6b1fccc6',
- 'phabricator-remarkup-css' => '5515b5b4',
+ 'phabricator-remarkup-css' => '2f159460',
'phabricator-shaped-request' => '322728f3',
- 'phabricator-side-menu-view-css' => '5515b5b4',
- 'phabricator-standard-page-view' => '5515b5b4',
+ 'phabricator-side-menu-view-css' => '2f159460',
+ 'phabricator-standard-page-view' => '2f159460',
'phabricator-textareautils' => '95ceba95',
'phabricator-tooltip' => '95ceba95',
- 'phabricator-transaction-view-css' => '5515b5b4',
- 'phabricator-zindex-css' => '5515b5b4',
- 'sprite-apps-large-css' => '5515b5b4',
- 'sprite-gradient-css' => '5515b5b4',
- 'sprite-icon-css' => '5515b5b4',
- 'sprite-menu-css' => '5515b5b4',
- 'syntax-highlighting-css' => '5515b5b4',
+ 'phabricator-transaction-view-css' => '2f159460',
+ 'phabricator-zindex-css' => '2f159460',
+ 'sprite-apps-large-css' => '2f159460',
+ 'sprite-gradient-css' => '2f159460',
+ 'sprite-icon-css' => '2f159460',
+ 'sprite-menu-css' => '2f159460',
+ 'syntax-highlighting-css' => '2f159460',
),
));
View
4 src/applications/files/controller/PhabricatorFileListController.php
@@ -90,7 +90,6 @@ private function buildFileList(array $files, array $highlighted_ids) {
$id = $file->getID();
$phid = $file->getPHID();
$name = $file->getName();
- $file_name = "F{$id} {$name}";
$file_uri = $this->getApplicationURI("/info/{$phid}/");
$date_created = phabricator_date($file->getDateCreated(), $user);
@@ -104,7 +103,8 @@ private function buildFileList(array $files, array $highlighted_ids) {
$item = id(new PhabricatorObjectItemView())
->setObject($file)
- ->setHeader($file_name)
+ ->setObjectName("F{$id}")
+ ->setHeader($name)
->setHref($file_uri)
->addAttribute($uploaded)
->addIcon('none', phabricator_format_bytes($file->getByteSize()));
View
5 src/applications/paste/controller/PhabricatorPasteListController.php
@@ -97,8 +97,11 @@ private function buildPasteList(array $pastes) {
'%s Line(s)',
new PhutilNumber($line_count));
+ $title = nonempty($paste->getTitle(), pht('(An Untitled Masterwork)'));
+
$item = id(new PhabricatorObjectItemView())
- ->setHeader($paste->getFullName())
+ ->setObjectName('P'.$paste->getID())
+ ->setHeader($title)
->setHref('/P'.$paste->getID())
->setObject($paste)
->addAttribute(pht('Created %s by %s', $created, $author))
View
3 src/applications/ponder/controller/PonderFeedController.php
@@ -92,7 +92,8 @@ private function buildQuestionListView(array $questions) {
$view->setNoDataString(pht('No matching questions.'));
foreach ($questions as $question) {
$item = new PhabricatorObjectItemView();
- $item->setHeader('Q'.$question->getID().' '.$question->getTitle());
+ $item->setObjectName('Q'.$question->getID());
+ $item->setHeader($question->getTitle());
$item->setHref('/Q'.$question->getID());
$item->setObject($question);
View
2 webroot/rsrc/css/layout/phabricator-object-item-list-view.css
@@ -347,10 +347,10 @@
.phabricator-object-list-cards .phabricator-object-item-name {
font-size: 13px;
+ white-space: nowrap;
}
.phabricator-object-list-cards .phabricator-object-item-link {
- white-space: nowrap;
padding: 6px 0;
}

0 comments on commit dcfe011

Please sign in to comment.