Permalink
Browse files

Remove line-related stats from Differential

Summary:
Ref T2825. Line stats are misleading when multiple commits are associated with a revision. It's better to have no data than misleading/bad data.

We can compute them accurately against commits via Fact/ETL at some point far in the future (see T1562 / T1135).

Test Plan: {F37519}

Reviewers: ptarjan

Reviewed By: ptarjan

CC: aran

Maniphest Tasks: T2825

Differential Revision: https://secure.phabricator.com/D5432
  • Loading branch information...
epriestley committed Mar 26, 2013
1 parent 426862b commit ebdf5d12de5e337f1808d638b08855e3321d3aac
Showing with 0 additions and 9 deletions.
  1. +0 −9 src/applications/differential/view/DifferentialRevisionStatsView.php
@@ -46,7 +46,6 @@ public function render() {
$dates = array();
$counts = array();
- $lines = array();
$days_with_diffs = array();
$count_active = array();
$response_time = array();
@@ -62,7 +61,6 @@ public function render() {
) as $age) {
$dates[$age] = strtotime($age . ' ago 23:59:59');
$counts[$age] = 0;
- $lines[$age] = 0;
$count_active[$age] = 0;
$response_time[$age] = array();
}
@@ -96,9 +94,6 @@ public function render() {
}
if (!$revision_seen) {
- if ($rev) {
- $lines[$age] += $rev->getLineCount();
- }
$counts[$age]++;
if (!$old_daycount) {
$count_active[$age]++;
@@ -125,13 +120,9 @@ public function render() {
$row_array[$age] = array(
pht('Revisions per week') => number_format($counts[$age] / $weeks, 2),
- pht('Lines per week') => number_format($lines[$age] / $weeks, 1),
pht('Active days per week') =>
number_format($count_active[$age] / $weeks, 1),
pht('Revisions') => number_format($counts[$age]),
- pht('Lines') => number_format($lines[$age]),
- pht('Lines per diff') => number_format($lines[$age] /
- ($counts[$age] + 0.0001)),
pht('Active days') => number_format($count_active[$age]),
);

0 comments on commit ebdf5d1

Please sign in to comment.