Skip to content
Commits on Feb 9, 2016
  1. @epriestley

    Add a basic progress bar for milestones

    epriestley committed
    Summary: Ref T4427. This kind of works.
    
    Test Plan: {F1100578}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T4427
    
    Differential Revision: https://secure.phabricator.com/D15221
  2. @epriestley

    Support enabling a formal points field in Maniphest

    epriestley committed
    Summary:
    Ref T4427.
    
      - New config option for labels, enabling, etc., but no UI/niceness yet.
      - When enabled, add a field.
      - Allow nonnegative values, including fractional values.
      - EditEngine is nice and Conduit / actions basically just work with a tiny bit of extra support code.
    
    Test Plan:
      - Edited points via "Edit".
      - Edited points via Conduit.
      - Edited points via stacked actions.
      - Tried to set "zebra" points.
      - Tried to set -1 points.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T4427
    
    Differential Revision: https://secure.phabricator.com/D15220
Commits on Feb 8, 2016
  1. @epriestley

    First cut of progress bars (PHUISegmentBarView)

    epriestley committed
    Summary:
    Ref T10288.
    
    I couldn't figure out how to reasonably get the interior right borders to round like the mock, but I think this is otherwise mostly faithful. Feel free to fix stuff.
    
    Test Plan: {F1100415}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10288
    
    Differential Revision: https://secure.phabricator.com/D15219
  2. @epriestley

    Add a "points" field to tasks

    epriestley committed
    Summary:
    Currently never read or written.
    
    Supports fractions.
    
    There's no such thing as an unsigned double so this also supports negative values, technically, although I'll eventually prevent this in the UI.
    
    Test Plan: `bin/storage upgrade`, then created and edited a task. Nothing was different.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15218
  3. @epriestley

    Remove three ancient columns from Maniphest tasks: attached, projectP…

    epriestley committed
    …HIDs, ccPHIDs
    
    Summary:
    Before edges, we stored some of this stuff directly on tasks.
    
      - `attached` was migrated to edges in Jan 2013.
      - `projectPHIDs` was never used, as far as I can tell?
      - `ccPHIDs` was migrated away and dropped more than a year ago.
    
    None of these columns are used in modern code (instead, modern code uses edges).
    
    Test Plan: `grep`, browsed around, `bin/storage upgrade`, unit tests.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15216
  4. @epriestley

    Allow workboards to be disabled, hiding "(Backlog)" column annotations

    epriestley committed
    Summary:
    Fixes T7410.
    
      - Adds a "Disable Workboard" action to the "Manage Backlog" menu.
      - We'll probably move this somewhere else if/when that column gets too messy.
      - Disabling a board hides it, prevents it from being recreated by non-editors, and hides the "Project (Backlog)" annotations.
      - Resotring a board puts it back in pristine condition.
    
    Test Plan:
      - Disabled a board.
      - Verified "(Backlog)" annotations vanished.
      - Enabled a board.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Subscribers: mbishopim3
    
    Maniphest Tasks: T7410
    
    Differential Revision: https://secure.phabricator.com/D15215
  5. @chadlittle

    Tidy up Workboard CSS a little

    chadlittle committed
    Summary:
     - Custom scrollbars, colors
     - New div with some better padding (floor for the column)
     - More consistent spacing around the board itself.
     - Slightly darker columns
     - Smaller horizonal scrollbar
    
    Test Plan:
    Chrome Mac / Desktop.
    
    {F1100342}
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15217
  6. @epriestley

    Fix a bad call when prefilling ApplicationSearch from `?projects=some…

    epriestley committed
    …_slug`
    
    Summary: Fixes T10299.
    
    Test Plan:
      - Visited `/maniphest/?projects=x` locally, where `x` is some valid project slug.
      - Before patch: Fatal on `requireViewer()` call.
      - After patch: Works correctly, filling the correct project into parameters.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10299
    
    Differential Revision: https://secure.phabricator.com/D15214
  7. @epriestley

    Only prevent drag-scroll in the Y direction on workboards

    epriestley committed
    Summary: This scroll lock thing prevented both X and Y scrolling, but should only prevent Y scrolling. Dragging a card to the edge to scroll left/right is fine.
    
    Test Plan: Scrolled a workboard left/right by dragging a card to the edge.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15213
  8. @epriestley

    Allow workboards to be panned horizontally by dragging the background

    epriestley committed
    Summary:
    Ref T5240. For boards with a lot of columns and users without "shift + mousewheel" or a touchpad, allow click-drag on the board background to pan the board horizontally.
    
    The `ew-resize` cursor cue might be a little too intense. If it's annoying, we could drop it and just leave this as a secret feature to discover.
    
    Test Plan: Panned the board horizontally.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T5240
    
    Differential Revision: https://secure.phabricator.com/D15211
  9. @epriestley

    Make workboard columns fixed-height and internally scrollable

    epriestley committed
    Summary:
    Ref T5240.
    
      - Columns are fixed height.
      - Columns scroll internally.
      - Drag behaviors generally align with these column behaviors.
    
    Test Plan: {F1099061}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T5240
    
    Differential Revision: https://secure.phabricator.com/D15209
  10. @epriestley

    Make waving cover files around on boards more reliable

    epriestley committed
    Summary:
    Currently, in Safari, if you drag an image onto a board to make it a cover file and then wave it around wildly a lot over differnent cards, it sometimes glitches out a bit and won't drop on them properly.
    
    This appears to be because sequencing and delivery of dragenter/dragleave events isn't always totally ideal.
    
    Instead, just cancel any existing drag when we get a new drag that targets a new drop target.
    
    Test Plan:
      - Opened a board with a bunch of cards.
      - Dragged a file from my desktop onto the board.
      - Waved it around wildly, hovering over many different cards.
        - Before patch: sometimes cards under the cursor stopped highlighting properly.
        - After patch: behavior seems correct and consistent.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15208
  11. @mrkane27 @epriestley

    fix a typo in troubleshooting perf wiki page

    mrkane27 committed with epriestley
    Summary: Fix typo. That said, I love the example.
    
    Test Plan: no
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15210
Commits on Feb 7, 2016
  1. @jcowgar @epriestley

    Fix an issue where 'Attending' would appear on calendar view unnecess…

    jcowgar committed with epriestley
    …arily
    
    Summary:
    Ref T10295
    
    * Viewing Upcoming Events in the calendar would display 'Attending: ' even if there were not attendees. This caused confusion, such as 'Is it telling me I am "Attending?"'
    * When a calendar event has no attendees, simply do not display the 'Attending: ' label
    
    Test Plan:
    * Add a new event with no one attending.
    * Add a new event with one or more attendees.
    * View the Upcoming Events query of the Calendar app.
    * Notice how the one with no attendees does not show 'Attending: ' while the other with attendees will show the already existing 'Attending: jdoe, ssmith' label.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T10295
    
    Differential Revision: https://secure.phabricator.com/D15207
  2. @epriestley

    Fix an issue with viewing an empty board with milestone columns

    epriestley committed
    Summary:
    Ref T10010.
    
      - Viewing an empty board with milestone columns did a meaningless edge query. Don't do that.
      - When creating the first milestone of a parent, force the indexing engine to rematerialize it inline. This sets `hasMilestones` properly. Otherwise, the daemons may take some time to fix this in the indexer.
    
    Test Plan:
      - Viewed an empty board of a project with a milestone.
      - Viewed a normal board.
      - Created the first milestone of a project with a big queue of daemons, saw project state immediately fully reflect the project having milestones.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10010
    
    Differential Revision: https://secure.phabricator.com/D15206
  3. @epriestley

    Make printing workboards work OK

    epriestley committed
    Summary:
    Fixes T7844. This isn't going to win any awards, but it has all the information.
    
    Mostly, we don't (or shouldn't, at least?) need the global `static` stuff anymore because we dropped the top-level custom scrollbar.
    
    Test Plan: Printed a PDF of a workboard, got all the cards in the output.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T7844
    
    Differential Revision: https://secure.phabricator.com/D15205
  4. @epriestley

    Link proxy column headers on workboards to proxied projects

    epriestley committed
    Summary: Ref T10010. Allows you to click "Milestone 99" to jump directly to that project.
    
    Test Plan:
      - Clicked milestone header, went to milestone.
      - Clicked normal column header, nothing happened. Wow!
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10010
    
    Differential Revision: https://secure.phabricator.com/D15204
  5. @epriestley

    Scale up small cover images instead of surrounding them with empty space

    epriestley committed
    Summary: This makes small cover images full-width instead of teeny tiny dots in the middle of an island of whitespace.
    
    Test Plan: Uploaded a small cover image.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15203
Commits on Feb 6, 2016
  1. @epriestley

    Support drag-and-drop to set cover images on workboard cards

    epriestley committed
    Summary: This was slightly more complex than I believed, but not too terrible.
    
    Test Plan:
    {F1096126}
    
      - Also used some normal file uploaders to make sure I didn't break that.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15202
  2. @epriestley

    Add storage and read logic for workboard card cover photos

    epriestley committed
    Summary:
    No way to set photos yet, but if you magic them in they work.
    
    Primarily, this consolidates rendering logic so the move + edit + view controllers all run the same code to do tags / cover photos.
    
    Test Plan: {F1095870}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15201
  3. @epriestley

    Disable "Subprojects" menu item for milestone projects

    epriestley committed
    Summary:
    Ref T10010. Milestones can't have subprojects, so this item isn't very useful.
    
    I think there is also an argument for disabling "Members", but that panel is a little less useless and explains the membership rule, so I'm less certain about removing it. I do generally lean toward removing it at some point, though.
    
    Test Plan:
      - Viewed a milestone, no "Subprojects" menu item.
      - Viewed a normal project, saw item.
      - Edited both menus, saw consistent UI.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10010
    
    Differential Revision: https://secure.phabricator.com/D15200
  4. @epriestley

    Don't show archived projects by default in policy control

    epriestley committed
    Summary:
    When filling in filler projects, only select active ones.
    
    Also use a slightly more modern method signature.
    
    Test Plan: Disabled a project, saw it vanish from the control.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15199
  5. @chadlittle

    Add a coverImage field to PHUIObjectItemView

    chadlittle committed
    Summary: Allows setting of an image to a Workboard card. (Hides from regular view, just in case).
    
    Test Plan: Fake setting a Pholio Mock image.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15198
  6. @epriestley

    Move drag ghosts above dialogs

    epriestley committed
    Summary: These currently have a z-index which puts them beneath dialogs, which doesn't work well for dialogs like "Reorder Columns" on workboards.
    
    Test Plan:
      - Dragged columns on a workboard in the "Reorder Columns" dialog.
      - Dragged normal stuff, too.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15197
  7. @epriestley

    Fix issue with rendering policy controls when an install has zero pro…

    epriestley committed
    …jects
    
    Fixes T10290.
    
    Auditors: cahd
Commits on Feb 5, 2016
  1. @epriestley

    Provide "Initial Members" instead of default joining projects

    epriestley committed
    Summary:
    Ref T10010. Instead of autojoining projects, provide "Initial Members: [___]" that the user can fill in.
    
    This is only available in the web UI when creating a (non-milestone) project.
    
    Test Plan:
      - Created a new project with no members.
      - Created a new project with some members.
      - Created a new milestone (no control).
      - Created a new project with myself as a member and an "Editable By: Project Members" policy, to verify this use case still works properly.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10010
    
    Differential Revision: https://secure.phabricator.com/D15195
  2. @chadlittle

    Style Milestone workpanels

    chadlittle committed
    Summary: Small amount of color, icon spacing
    
    Test Plan: Review milestone panels on parent project
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15196
  3. @chadlittle

    Add a map marker icon for Milestones

    chadlittle committed
    Summary: Never got added.
    
    Test Plan: Select a Milestone Project, edit Picture, see marker.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15194
  4. @chadlittle

    Add getDisplayName to cards and profiles

    chadlittle committed
    Summary: Show on hovercards and the profile page itself.
    
    Test Plan: Review a Milestone.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15193
  5. @chadlittle

    Normalize icon color on user/project lists.

    chadlittle committed
    Summary: Minor, just fall back to the grey icon in all cases (too much color for me).
    
    Test Plan: Review a Project and a Profile
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15190
  6. @epriestley

    Add user profile icons to Phame authorship

    epriestley committed
    Summary: Huge omission.
    
    Test Plan: {F1093955}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Differential Revision: https://secure.phabricator.com/D15192
  7. @epriestley

    Improve type and icon information in typeahead

    epriestley committed
    Summary:
    Ref T10289. This probably doesn't cover everything but should do a little bit better.
    
    Although we should mabye just exlude milestones from this menu completely?
    
    Test Plan: {F1093937}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10289
    
    Differential Revision: https://secure.phabricator.com/D15191
  8. @epriestley

    Fix dead column link and provide more milestone UI context

    epriestley committed
    Summary:
    Fixes T10287. Ref T10286.
    
      - Link stuff properly.
      - Generally, show "Parent (Milestone)" instead of "Milestone".
      - This probably doesn't get 100% of `getName()` -> `getDisplayName()` swaps, but we can get those as we catch them.
    
    Test Plan: See T10286. Also clicked stuff.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T10286, T10287
    
    Differential Revision: https://secure.phabricator.com/D15189
  9. @chadlittle

    Slightly better spacing, colors on ProjectCards

    chadlittle committed
    Summary: Fixes transparent background images, removes "checkered". Better spacing for tags.
    
    Test Plan:
    Upload a transparent logo, hover over project.
    
    {F1093753}
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D15188
  10. @epriestley

    De-garbage the horrible garbage project section of the policy selecti…

    epriestley committed
    …on control
    
    Summary:
    Fixes T4136.
    
    When listing projects in the "Visible To" selector control:
    
      - Instead of showing every project you are a member of, show only a few.
      - Add an option to choose something else which isn't in the menu.
      - If you've used the control before, show the stuff you've selected in the recent past.
      - If you haven't used the control before or haven't used it much, show the stuff you've picked and them some filler.
      - Don't offer milestones.
      - Also don't offer milestones in the custom policy UI.
    
    Test Plan:
    {F1091999}
    
    {F1092000}
    
      - Selected a project.
      - Used "find" to select a different project.
      - Saw reasonable defaults.
      - Saw favorites stick.
      - Tried to typeahead a milestone (nope).
      - Used "Custom Policy", tried to typeahead a milestone (nope).
      - Used "Custom Policy" in general.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T4136
    
    Differential Revision: https://secure.phabricator.com/D15184
Something went wrong with that request. Please try again.