Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: master
Commits on Aug 4, 2015
  1. @chadlittle

    Add Edit/View Policy to Ponder Questions

    chadlittle authored
    Summary: Ref T3578, adds ability to set a default edit and view policy for questions. Not sure what to set viewPolicy to ?
    
    Test Plan: Test an old question, edit policy still on myself. Test a new question, see new default.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T3578
    
    Differential Revision: https://secure.phabricator.com/D13791
  2. @epriestley

    Document how to use `harbormaster.sendmessage` to report lint and uni…

    epriestley authored
    …t results
    
    Summary: Fixes T7419. This doesn't really do anything, just adds documentation.
    
    Test Plan:
      - Read the documentation:
    
    {F688899}
    
      - Created a build plan which makes an HTTP request to `example.com` and waits for a result.
      - Ran that build plan manually.
      - Called `harbormaster.sendmessage` manually with the example lint/unit values to provide a result.
      - Saw the results report correctly and the message ("fail") process as expected:
    
    {F688902}
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T7419
    
    Differential Revision: https://secure.phabricator.com/D13789
  3. @chadlittle

    Set a max-height on codeblocks in Conpherence

    chadlittle authored
    Summary: Code blocks in Conpherence can be massive and disruptive to a chat-like experience. This caps the height.
    
    Test Plan: Add a ginormous code block to Conpherence, see it hit max-height
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D13790
  4. @chadlittle

    Add mailKeys to Ponder Answer

    chadlittle authored
    Summary: Ref T3846. Adds mailkey generation and migration.
    
    Test Plan: Ran the migration, see keys in mysql.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T3846
    
    Differential Revision: https://secure.phabricator.com/D13785
  5. @chadlittle

    Add mobile menu to Ponder

    chadlittle authored
    Summary: Ref T3578, adds mobile menus to Ponder
    
    Test Plan: Test Ponder on mobile and desktop, click in Ask Question links
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T3578
    
    Differential Revision: https://secure.phabricator.com/D13784
  6. @chadlittle

    Update XHPhast for handleRequest

    chadlittle authored
    Summary: Updates XHPhast
    
    Test Plan: Ran a few queries
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Differential Revision: https://secure.phabricator.com/D13776
  7. @chadlittle

    Update Notifications for handleRequest

    chadlittle authored
    Summary: Updates Notifcations for handleRequest
    
    Test Plan: Test as much as I could, mark all, view, lists.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13767
  8. @chadlittle

    Update Settings for handleRequest

    chadlittle authored
    Summary: Run through the Settings controllers
    
    Test Plan: Test various settings pages, save some settings.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Differential Revision: https://secure.phabricator.com/D13775
  9. @chadlittle

    Remove device=false from Daemons application

    chadlittle authored
    Summary: Fixes T9064, marks page as mobile ready.
    
    Test Plan: Shrink Page
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T9064
    
    Differential Revision: https://secure.phabricator.com/D13783
  10. @epriestley

    Fix some copy/paste slop with BLOCK actions in Herald transcripts

    epriestley authored
    Summary: Fixes T9060. These actions still work fine, but the transcripts got messed up a bit.
    
    Test Plan: Viewed transcripts with blocking actions.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T9060
    
    Differential Revision: https://secure.phabricator.com/D13782
  11. @epriestley

    Fix undefined ACTION_BLOCK class constant in Herald

    epriestley authored
    Summary: Fixes T9054. This didn't get fully cleaned up.
    
    Test Plan: Edited several rules, saw actions faithfully represented.
    
    Reviewers: joshuaspence, chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T9054
    
    Differential Revision: https://secure.phabricator.com/D13781
Commits on Aug 3, 2015
  1. @epriestley

    Put spaces back in condition rendering

    epriestley authored
    Summary: Fixes T9055. I mostly tested with "Always" rules so I missed this.
    
    Test Plan: {F687280}
    
    Reviewers: chad, joshuaspence
    
    Reviewed By: joshuaspence
    
    Maniphest Tasks: T9055
    
    Differential Revision: https://secure.phabricator.com/D13780
  2. @joshuaspence

    Mark `renderActionDescription` as abstract

    joshuaspence authored
    Summary:
    I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:
    
    ```
    Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()
    
    /usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896
    ```
    
    Test Plan: N/A
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D13779
  3. @epriestley

    Share target filtering code in HeraldAction

    epriestley authored
    Ref T8726. This shares some target filtering code with the base class.
  4. @epriestley

    Modularize the Diffusion/Differential "Block" Herald actions

    epriestley authored
    Also removes HeraldCustomAction. This completes action modularization.
    
    Ref T8726.
  5. @epriestley
  6. @epriestley

    Modularize the Harbormaster "Run build plan" Herald action

    epriestley authored
    Ref T8726. Modularizes "Run build plan" in Differential and Diffusion.
  7. @epriestley

    Modularize the Legalpad "Require Signature" Herald Action

    epriestley authored
    Ref T8726. Modularizes "Require Signatures" for Legalpad.
  8. @epriestley

    Modularize Differential Reviewer actions in Herald

    epriestley authored
    Ref T8726. Modularizes the "Add Reviewers" and "Add Blocking Reviewers" Herald actions.
  9. @epriestley

    Modularize Maniphest Herald "Assign Task" action

    epriestley authored
    Summary: Ref T8726. No surprises here.
    
    Test Plan:
      - Created rules using this action.
      - Applied migration.
      - Verified rules still work.
    
    {F659324}
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T8726
    
    Differential Revision: https://secure.phabricator.com/D13706
  10. @epriestley

    Modularize "add projects" and "remove projects" Herald actions

    epriestley authored
    Summary: Ref T8726. Convert these to be modular.
    
    Test Plan:
      - Created rules using these actions.
      - Upgraded them.
      - Verified they still work.
    
    {F659266}
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T8726
    
    Differential Revision: https://secure.phabricator.com/D13705
  11. @epriestley

    Modularize "Send an Email" Herald actions

    epriestley authored
    Summary: Ref T8726. No surprises.
    
    Test Plan:
    Created rules using both action variants, applied upgrade, saw rules still work correctly.
    
    {F658842}
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T8726
    
    Differential Revision: https://secure.phabricator.com/D13701
  12. @epriestley

    Make "Add Subscribers" and "Remove Subscribers" Herald actions modular

    epriestley authored
    Summary: Ref T8726. Converts these actions to be modular. No real surprises in this change.
    
    Test Plan:
    {F658709}
    
      - Wrote some rules.
      - Migrated them forward.
      - Used a bunch of these rules.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T8726
    
    Differential Revision: https://secure.phabricator.com/D13699
  13. @epriestley

    Modularize Herald "flag" action, plus update transcripts

    epriestley authored
    Summary:
    Ref T8726. This modularizes "Mark with flag", plus rebuilds transcripts in a more modern/flexible way. The big transcript stuff is:
    
      - Transcripts are now translatable.
      - Transcripts can now show multiple outputs from a single action. For example, an action like "add A, B, C to subscribers" can now say "added A; B is invalid; C was already subscribed".
    
    Test Plan: {F637784}
    
    Reviewers: chad, btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, eadler, epriestley
    
    Maniphest Tasks: T8726
    
    Differential Revision: https://secure.phabricator.com/D13649
  14. @epriestley

    Make Herald action modularization more aggressive

    epriestley authored
    Summary:
    Ref T8726. Herald actions are technically sort-of modular already, but make them more aggressively modular similar to `HeraldField`.
    
    I plan to obsolete and replace `HeraldCustomAction`.
    
    Test Plan: Saw actions in nice groups; created and ran a "Do Nothing" action. Transcripts are a bit rough for now.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T8726
    
    Differential Revision: https://secure.phabricator.com/D13646
  15. @epriestley

    Fix 'key'/'type' swap in email reset / one-time-login controller

    epriestley authored
    Summary: Fixes T9046. These got swapped around during refactoring.
    
    Test Plan:
      - Used `bin/auth recover` prior to patch (failed).
      - Used `bin/auth recover` after patch (worked).
    
    Reviewers: joshuaspence, chad
    
    Reviewed By: chad
    
    Subscribers: epriestley
    
    Maniphest Tasks: T9046
    
    Differential Revision: https://secure.phabricator.com/D13778
  16. @lpriestley

    Calendar list objects that are ghost events should link to a ghost ev…

    lpriestley authored
    …ent, not the parent
    
    Summary: Fixes T9034, Calendar list objects that are ghost events should link to a ghost event, not the parent.
    
    Test Plan: Open All Events in Calendar, make sure ghost objects open the ghost instance, not the parent instance.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T9034
    
    Differential Revision: https://secure.phabricator.com/D13764
Commits on Aug 2, 2015
  1. @chadlittle

    Partially update Maniphest for handleProcess

    chadlittle authored
    Summary: Starts conversion of Maniphest to handleProcess, chopping up to reduce errors.
    
    Test Plan: New Task, Edit Task, Change Priority, Move on workboard, view reports, batch edit tasks
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13773
Commits on Aug 1, 2015
  1. @chadlittle

    Update Audit for handleRequest

    chadlittle authored
    Summary: Updates Audit controllers for handleRequest
    
    Test Plan: See list of audits, raise concern, clear concern, comment.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13771
  2. @chadlittle

    Update Auth for handleRequest

    chadlittle authored
    Summary: Updates Auth app for handleRequest
    
    Test Plan: Tested what I could, Log in, Log out, Change Password, New account, Verify account... but extra eyes very helpful here.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13748
  3. @chadlittle

    Update Phortune for handleRequest

    chadlittle authored
    Summary: Updates Phortune controllers for handleRequest
    
    Test Plan: New Invoice, new merchant, new subscriptions, manual bill, pay bill, anything I could find to test.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13768
  4. @chadlittle

    Update Calendar for handleRequest

    chadlittle authored
    Summary: Run through Calendar and update/cleanup processRequest
    
    Test Plan: New Event, Edit, etc.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13747
  5. @chadlittle

    Update Paste for handleRequest

    chadlittle authored
    Summary: Updates Paste
    
    Test Plan: New paste, edit, view lists
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13766
  6. @chadlittle

    Update XHProf for handleRequest

    chadlittle authored
    Summary: Updates XHProf for handleRequest
    
    Test Plan: Use XHProf
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13770
  7. @chadlittle

    Update Herald for handleRequest

    chadlittle authored
    Summary: Update Herald for handleRequest
    
    Test Plan: New rule, test console, logs, lists.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8628
    
    Differential Revision: https://secure.phabricator.com/D13765
Something went wrong with that request. Please try again.