Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: master
Commits on Jul 2, 2015
  1. @epriestley

    Fix "Add Project" in bulk editor

    epriestley authored
    Summary: Fixes T8740. This data is required for now, and didn't get brought across properly from the original standalone foreground editor.
    
    Test Plan: Did a bulk editor "add project", got a clean result.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8740
    
    Differential Revision: https://secure.phabricator.com/D13533
  2. @epriestley

    Fix a couple of minor Nuance / transaction publisher issues

    epriestley authored
    Summary: I got a couple of tasks stuck in my local queue a while ago when touching Nuance, fix a couple minor issues to clean them up.
    
    Test Plan: Ran tasks in queue, got clean results.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D13532
  3. @epriestley

    Allow unit test duration to be submitted as a float or an int

    epriestley authored
    Summary: Fixes T8736. It's OK for duration to be something that comes out of JSON as an int, like `1`.
    
    Test Plan: Will make @hach-que verify.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley, hach-que
    
    Maniphest Tasks: T8736
    
    Differential Revision: https://secure.phabricator.com/D13531
Commits on Jul 1, 2015
  1. @epriestley

    Remove "feed.public" and sort out feed policies

    epriestley authored
    Summary:
    Ref T6817. Fixes T8731. On the old `secure` host, `feed.public` was set to `true`. I didn't bring the option over, which caused the secondary issue in T8731.
    
    Specifically, when `feed.public` is off, a logged-out user looking at feed can't see //any// stories, so they query all of feed until they hit the time limit.
    
    To fix this immediately, just use the most open policy, which is basically equivalent but always correct.
    
    To fix this more thoroughly:
    
      - Remove `feed.public`, which violates policies and has been slated for removal for a while (see T6817).
      - Clean up policy handling.
    
    Test Plan:
      - As a logged-out user, viewed feed on a public install with `feed.public` off; no longer saw all stories get queried + no feed shown.
      - Grepped for `feed.public`.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: chad, epriestley
    
    Maniphest Tasks: T6817, T8731
    
    Differential Revision: https://secure.phabricator.com/D13518
  2. @epriestley

    Fix some pht-strings

    epriestley authored
    Summary: This correct some bad strings for translations
    
    Test Plan:
    merge similar stings
    removes some word wraps
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T8700
    
    Differential Revision: https://secure.phabricator.com/D13464
  3. @epriestley

    Don't put objects into the query workspace by default

    epriestley authored
    Summary:
    Ref T8731. I think the issue is that some `ProjectQuery` (without needImages()) populates the query workspace, then the "real" one hits the workspace.
    
    Instead, only populate the workspace from ObjectQuery, so we know that objects in the workspace always have whatever ObjectQuery attaches to them.
    
    Test Plan: Verified this didn't destroy the cache hitrate, but I can't repro the original issue locally per se.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: chad, epriestley
    
    Maniphest Tasks: T8731
    
    Differential Revision: https://secure.phabricator.com/D13516
Commits on Jun 30, 2015
  1. @lpriestley

    Commenting on instances of a recurring event should create a new even…

    lpriestley authored
    …t with its own comments
    
    Summary: Closes T8696, Commenting on instances of a recurring event should create a new event with its own comments
    
    Test Plan: Open recurring event instance (not exception), should see no timeline, leave a comment, an exception to event should be created.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8696
    
    Differential Revision: https://secure.phabricator.com/D13481
  2. @epriestley

    Fix infinite loop in renderAccessDenied()

    epriestley authored
    Summary:
    Fixes T8727. When I added `setParentQuery()`, I increased the cache hit rate but also accidentally propagated policy exception settings.
    
    Instead, make the policy exception beahvior explicit: no exceptions should be raised when querying handles.
    
    Test Plan: Will test production.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8727
    
    Differential Revision: https://secure.phabricator.com/D13489
  3. @epriestley

    Cache remarkup engines in Feed

    epriestley authored
    Summary: Ref T8631. This method uses cached settings.
    
    Test Plan: Saw 40% performance improvement locally (reduced 200ms of 500ms).
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8631
    
    Differential Revision: https://secure.phabricator.com/D13480
  4. @epriestley

    Dramatically increase cache hit rate for feed

    epriestley authored
    Summary:
    Ref T8631. The query plan for feed stories is really bad right now, because we miss caches we should be hitting:
    
      - The workspace cache is stored at each query, so adjacent queries can't benefit from the cache (only subqueries). Feed has primarily sibling queries.
        - There is no technical reason to do this. Store the workspace cache on the root query, so sibling queries can hit it.
      - In `ObjectQuery`, we check the workspace once, then load all the PHIDs. When the PHIDs are a mixture of transactions and objects, we always miss the workspace and load the objects twice.
        - Instead, check the workspace after loading each type of object.
      - `HandleQuery` does not set itself as the parent query for `ObjectQuery`, so handles never hit the workspace cache.
        - Pass it, so they can hit the workspace cache.
      - Feed's weird `PhabricatorFeedStory::loadAllFromRows()` method does not specify a parent query on its object/handle queries.
        - Just declare the object query to be the "root" query until this eventually gets cleaned up.
    
    Test Plan: Saw queries for each object drop from 4-6x to 1x in `/feed/`.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8631
    
    Differential Revision: https://secure.phabricator.com/D13479
  5. @epriestley

    Don't try to load profile images for projects with no profile image

    epriestley authored
    Summary: Ref T8631. Projects may not have a profile image PHID; don't try to load it if they don't.
    
    Test Plan: Saw `WHERE phid IN ('')` query stop happening on a local feed story page.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8631
    
    Differential Revision: https://secure.phabricator.com/D13476
  6. @epriestley

    Don't require missing fields be present in order to subscribe to an o…

    epriestley authored
    …bject
    
    Summary: Fixes T8719. It's fine to subscribe to objects that don't have all their required fields filled in.
    
    Test Plan: Subscribed/unsubscribed from an object.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8719
    
    Differential Revision: https://secure.phabricator.com/D13484
  7. @epriestley

    Let PhabricatorPlatformSite catch unconfigured requests

    epriestley authored
    Summary: Fix T8717. If the install didn't configure base-uri, assume they want Phabricator; We'll later show the setup warning about it.
    
    Test Plan: Set base-uri to something else, see short error. Delete it, see Phabricator.
    
    Reviewers: laomoi, #blessed_reviewers, epriestley
    
    Reviewed By: laomoi, #blessed_reviewers, epriestley
    
    Subscribers: laomoi, epriestley, Korvin
    
    Maniphest Tasks: T8717
    
    Differential Revision: https://secure.phabricator.com/D13482
  8. @epriestley

    Don't put the entire corpus into project edit feed stories

    epriestley authored
    Summary: Fixes T8723. We override timeline titles for these fields to shorten them, but the parent class shows full values for feed edits, which can lead to screen-sized notifications.
    
    Test Plan: Edited a project, saw a reasonably-sized notification for it.
    
    Reviewers: btrahan, chad
    
    Reviewed By: chad
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8723
    
    Differential Revision: https://secure.phabricator.com/D13485
Commits on Jun 29, 2015
  1. @epriestley

    Modularize Aphront "sites"

    epriestley authored
    Summary:
    Fixes T5702. The path here is long and windy:
    
      - I want to move `blog.phacility.com` to the new `secure` host.
      - That host has `security.require-https` set, which I want to keep set (before, this was handled in a sort of hacky way at the nginx/preamble level, but I've cleaned up everything else now).
      - Currently, that setting forces blogs to HTTPS too, which won't work.
      - To let blogs be individually configurable, we need to either modularize site config or make things hackier.
      - Modularize rather than increasing hackiness.
      - Also add a little "modules" panel in Config. See T6859. This feels like a reasonable middle ground between putting this stuff in Applications and burying it in `bin/somewhere`.
    
    Test Plan:
      - Visited normal site.
      - Visited phame on-domain site.
      - Visited phame off-domain site.
      - Viewed static resources.
    
    {F561897}
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T5702
    
    Differential Revision: https://secure.phabricator.com/D13474
  2. @bobtrahan

    Spaces + Diffusion - make creating a new repository work again

    bobtrahan authored
    Summary: Fixes T8702. Needed to teach these controls how to serialize / unserialize themselves in that they are storing two values (policy phid + space phid) nowadays
    
    Test Plan: made a new repo successfully with policy as described in T8702. Also edited policy successfully.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8702
    
    Differential Revision: https://secure.phabricator.com/D13472
  3. @epriestley

    Modernize transaction comment editor

    epriestley authored
    Summary: Fixes T8703. The URI handling here was a little unusual.
    
    Test Plan:
      - Edited and deleted comments in several applications, including Macro.
      - As an admin, deleted others' comments.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8703
    
    Differential Revision: https://secure.phabricator.com/D13469
Commits on Jun 28, 2015
  1. @epriestley
Commits on Jun 27, 2015
  1. @epriestley

    Stop running a second symbol migration

    epriestley authored
    Fixes T8697.
  2. @lpriestley

    Events should offer Spaces as the view policy options

    lpriestley authored
    Summary: Ref T8687, Events should offer Spaces as the view policy options
    
    Test Plan: Create event, choose default Space, save, edit, choose different Space, save, new policy should be reflected on Event.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8687
    
    Differential Revision: https://secure.phabricator.com/D13459
  3. @lpriestley

    Popup datepicker should respect user preferred week start day

    lpriestley authored
    Summary: Fixes T8605, Popup datepicker should respect user preferred week start day
    
    Test Plan: Edit event, open datepicker, calendar weeks should start on Sunday by default, and another day, if specified in User Preferences.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8605
    
    Differential Revision: https://secure.phabricator.com/D13419
  4. @grimreaper @epriestley

    Remove duplicated duplicated words

    grimreaper authored epriestley committed
    Test Plan: eyeball it
    
    Reviewers: joshuaspence, #blessed_reviewers, epriestley
    
    Reviewed By: joshuaspence, #blessed_reviewers, epriestley
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D13462
  5. @epriestley

    Allow the omnipotent viewer to see objects in uninstalled applications

    epriestley authored
    Particularly, in the cluster, it needs to be able to see Almanac services.
    This permission may be conflated with the logged-out viewer, since neither
    have PHIDs.
    
    Auditors: btrahan
  6. @epriestley
Commits on Jun 26, 2015
  1. @epriestley

    Fix Alamanc service paging

    epriestley authored
    Summary: Ref T8686. This method has the wrong name and calls a nonexistent method on `$service`.
    
    Test Plan: Set page size to 5, paged locally, hit error, applied changes, got clean paging.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8686
    
    Differential Revision: https://secure.phabricator.com/D13460
  2. @lpriestley

    Set event policies like other event properties

    lpriestley authored
    Summary: Closes T8028, Set event policies like other event properties
    
    Test Plan: Create and edit events, make sure edit and view policies get populated and saved correctly.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8028
    
    Differential Revision: https://secure.phabricator.com/D13415
Commits on Jun 25, 2015
  1. @epriestley

    Don't try to strlen() an array

    epriestley authored
    This is definitely an array now.
    
    Auditors: joshuaspence
  2. @bobtrahan

    Conpherence - move crumb-based room edit to widget; other cleanup

    bobtrahan authored
    Summary:
    We use a non-standard way to invoke the edit dialogue (title, picture, etc) via the crumb. Stop doing that and instead use the widget technology to invoke the dialogue.
    
    This requires making the widget handling code a bit more nuanced as nothing has wanted to pop a dialogue before. I plan to clean this up as I add the action to "Mark as Favorite" to the UI. In particular, I want to stop rendering the un-used DOM and make a workflow-based widget action a property as opposed to something hardcoded. This may be too ambitious depending on how similar these workflows are....
    
    This also updates the ThreadSearchEngine to be a bit more modern. Additionally, go through making some user-facing strings a bit more sensical.
    
    Test Plan: changed settings from conpherence full and durable column successfully.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D13449
  3. @epriestley

    Do all push mail in a bunch at the end, too

    epriestley authored
    Summary: Same deal as transaction mail. Improves robustness.
    
    Test Plan: Pushed stuff.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D13451
  4. @lpriestley

    Set display mode for Upcoming Events builtin query so that no `$max_r…

    lpriestley authored
    …ange` is set on the query
    
    Summary: Fixes T8675, Set display mode for Upcoming Events builtin query so that no `$max_range` is set on the query
    
    Test Plan: Open Upcoming Events builtin query, max events returned should be size of the page (100 objects)
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: epriestley, Korvin
    
    Maniphest Tasks: T8675
    
    Differential Revision: https://secure.phabricator.com/D13447
  5. @epriestley

    Provide more detailed guidance on upgrading Phabricator and the "stab…

    epriestley authored
    …le" branch
    
    Summary: Maintaining "stable" is worthwhile now that we're running the cluster, so document its existence.
    
    Test Plan: Reading.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D13446
  6. @bobtrahan

    Conpherence - remove room vs message distinction as far as users are …

    bobtrahan authored
    …concerned
    
    Summary:
    Ref T8488, T8469, T8485.
    
    This is done in regards to T8488 as far as users are concerned. There's still some classes, and etc. that should be re-named probably. T8469 and T8485 are basically moot now though.
    
    Rather than having "Send Message" exposed, just expose "Create Room". Users get the full form. One change is "title" is now required.
    
    This diff removes the concept of "isRoom" entirely.
    
    Test Plan: Verifed a user with no conpherences had sensible data in both column view and full conpherence view. Created rooms with various policies and things worked well.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    Subscribers: chad, epriestley, Korvin
    
    Maniphest Tasks: T8469, T8485, T8488
    
    Differential Revision: https://secure.phabricator.com/D13351
  7. @epriestley

    Carefully avoid the harbormaster/differential race

    epriestley authored
    Summary: Ref T8650. This should stop the problem, but isn't a root cause fix. See discussion on the task.
    
    Test Plan: Made some local diffs, but this is a bit hard to reproduce reliably.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8650
    
    Differential Revision: https://secure.phabricator.com/D13441
  8. @epriestley

    Fix type spec for 'coverage'

    epriestley authored
    Summary: Ref T8670. The spec for "coverage" is incorrect, it's a map of paths to coverage information.
    
    Test Plan: See next diff.
    
    Reviewers: joshuaspence, btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8670
    
    Differential Revision: https://secure.phabricator.com/D13435
  9. @epriestley

    Fix an issue with handling of `null` feed URIs

    epriestley authored
    Summary: Ref T8658. Caught this in the logs. This value may be set to `null`. Handle that gracefully.
    
    Test Plan: Will check logs.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T8658
    
    Differential Revision: https://secure.phabricator.com/D13432
Something went wrong with that request. Please try again.