Add the audit state to the list view of Diffusion Repository Browser #522

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

tlayh commented Mar 1, 2014

Not sure if this is interesting for you, but I decided to share it, perhaps it is interesting for others to. For my team it is cool if the can see in the repository browser if a commit is already review or not. Helps us a lot.

Owner

epriestley commented Apr 22, 2014

This is fine conceptually but suffers from the N+1 query problem:

https://secure.phabricator.com/book/phabcontrib/article/n_plus_one/

If you'd like to build this feature, please file a feature request in Maniphest with a note that you'd like to build it and I'll walk you through how to implement it without performance issues:

https://secure.phabricator.com/maniphest/task/create/

Or, feel free to file a task requesting the feature, and we'll implement it in an upstreamable way eventually. We plan to add build status here soon too.

epriestley closed this Apr 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment