Add backticks around collation to avoid query error #729
Conversation
|
We're going to land a fix with https://secure.phabricator.com/D10641, but thanks for looking into this! |
|
Sure thing. Note that the changes to lines 195 and 196 addressed another error of the same type that D10641 doesn't. |
|
cc @bobtrahan |
|
Cool, I made https://secure.phabricator.com/D10646. Thanks for the help! |
bobtrahan
added a commit
that referenced
this pull request
Oct 6, 2014
…sort Summary: second bit of #729 Test Plan: this is a weird pull request merge Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D10646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Encountered the following when running
./bin/storage upgrade, with MySQL 5.1.67:The offending queries all contained `...COLLATE binary'. Adding backticks around "binary" solves the error and allows the migrations to run.