Open software engineering platform and fun adventure game
PHP JavaScript CSS C Roff Shell Other
Switch branches/tags
Nothing to show
Latest commit 0d8f417 Jul 21, 2017 @epriestley epriestley Fix an issue when deleting the entire content of an unsubmitted inlin…
…e comment

Summary: Ref T12733. In this case, the server returns no new `row`, but we would incorrectly try to bind to one.

Test Plan:
  - Created a new comment.
  - Edited it.
  - Deleted all the text.
  - Saved changes.
  - Before: Header continues to show phantom "1 Unsubmitted Comment", browser error log reflects one error.
  - After: Header reflects comment being deleted, error log is quiet.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision:

Phabricator is a collection of web applications which help software companies build better software.

Phabricator includes applications for:

  • reviewing and auditing source code;
  • hosting and browsing repositories;
  • tracking bugs;
  • managing projects;
  • conversing with team members;
  • assembling a party to venture forth;
  • writing stuff down and reading it later;
  • hiding stuff from coworkers; and
  • also some other things.

You can learn more about the project (and find links to documentation and resources) at

Phabricator is developed and maintained by Phacility.


For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.


We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.


Phabricator is released under the Apache 2.0 license except as otherwise noted.