Permalink
Switch branches/tags
Nothing to show
Commits on Feb 26, 2015
  1. Use sys_get_temp_dir(), not hardcoded "/tmp"

    epriestley committed Feb 26, 2015
    See: <#55>
  2. Fix a memory leak in the ignored function list

    epriestley committed Feb 26, 2015
    See:
    
      - <#60>
      - <#54>
  3. Add a failing test for auto_prepend_file

    epriestley committed Feb 26, 2015
    See <#48>.
Commits on Aug 28, 2014
  1. Fix broken XHProf unit tests

    epriestley committed Aug 28, 2014
    Summary:
    There are two broken tests. One (007) is easy to fix. It was failing because of array-to-string conversion warnings.
    
    Since I didn't want to add function calls because that would change the test output, I just silenced the warnings with "@".
    
    The other test (004) was also easy to fix but I can't really explain what's going on there. Seems like it works though? It shouldn't do anything bad, since we would have generated a meaningless "???_op" otherwise.
    
    Test Plan: Ran tests, tests passed.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10376
  2. Fix XHProf segfault when calling internal functions in PHP 5.5

    epriestley committed Aug 28, 2014
    Summary:
    Fixes <#33>. Since the issue with that patch was CLA, I developed this independently.
    
    This works because it just inlines the body of `execute_internal()`, which is nearly identical:
    
    ```
    ZEND_API void execute_internal(zend_execute_data *execute_data_ptr, zend_fcall_info *fci, int return_value_used TSRMLS_DC)
    {
    	if(fci != NULL) {
    		((zend_internal_function *) execute_data_ptr->function_state.function)->handler(fci->param_count,
    				*fci->retval_ptr_ptr, fci->retval_ptr_ptr, fci->object_ptr, 1 TSRMLS_CC);
    
    	} else {
    		zval **return_value_ptr = &EX_TMP_VAR(execute_data_ptr, execute_data_ptr->opline->result.var)->var.ptr;
    		((zend_internal_function *) execute_data_ptr->function_state.function)->handler(execute_data_ptr->opline->extended_value, *return_value_ptr,
    					(execute_data_ptr->function_state.function->common.fn_flags & ZEND_ACC_RETURN_REFERENCE)?return_value_ptr:NULL,
    					execute_data_ptr->object, return_value_used TSRMLS_CC);
    	}
    }
    ```
    
    Test Plan: Failing test now passes. No more segfaults on PHP 5.5.8.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10375
  3. Add a failing test case for the XHProf PHP 5.5 segfault

    epriestley committed Aug 28, 2014
    Summary:
    This adds a failing test case for the bug discussed in <#33>.
    
    It also adds a `bin/xhprofile` script which makes it easier to test stuff like this, by invoking the profiler on some other script. This isn't hugely useful in production but is valuable diagnostically, and helped me reduce this test case.
    
    Test Plan:
      - Ran `arc unit` and got a failure.
      - Verified that this test passes if `class_exists()` is commented out (which makes the test not segfault).
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10374
  4. Add a basic `arc unit` test binding to XHProf

    epriestley committed Aug 28, 2014
    Summary:
    This allows "arc unit" to more-or-less run the PHP extension tests in an approximately correct way.
    
    Note that there are two test failures at HEAD on recent PHP, and they've been failing for some time.
    
    Test Plan: Used `arc unit` to run some tests.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10373
  5. XHProf: add .arclint, fix some minor issues

    epriestley committed Aug 28, 2014
    Summary: Add a .arclint file and fix some stray tabs and whitespace issues.
    
    Test Plan: Built xhprof, ran tests (some failures, but preexisting).
    
    Reviewers: chad, btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10372
  6. Fix mismatched tag in contacts

    jwpage committed with epriestley Aug 28, 2014
    Summary: See <#42>.
    
    Reviewed by: epriestley
Commits on Aug 27, 2014
  1. Update .arcconfig and acknowledge that we're the new maintainers in X…

    epriestley committed Aug 27, 2014
    …HProf
    
    Summary: Modernize this stuff a bit.
    
    Test Plan: Ran `arc diff` to produce this diff. Read `CREDITS`.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10366
  2. Remove Composer support from XHProf

    epriestley committed Aug 27, 2014
    Summary:
    See <#40>. This is currently broken and extremely insecure.
    
    We may want to restore it eventually, but understanding composer is very complex (no one who touched this realized that the package was owned by someone unrelated to the project who can apparently redirect it at will with no accountability). No one on the ticket seems to have any reason why this isn't totally wide open, and I haven't gotten in touch with anyone in `#composer-dev`.
    
    Test Plan: N/A
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D10365
Commits on Apr 22, 2014
  1. Merge pull request #38 from facebook/packagexml

    billf committed Apr 22, 2014
    adjust contacts inside packing slip
Commits on Apr 21, 2014
Commits on Apr 14, 2014
  1. Merge pull request #24 from Rarst/callgraph-process

    billf committed Apr 14, 2014
    Tweaked proc_open() call for callgraph to work on Windows
Commits on Apr 12, 2014
Commits on Apr 11, 2014
  1. Merge pull request #30 from dshafik/fix-inlines

    billf committed Apr 11, 2014
    Change inline to static inline for C99 compliance with PHP 5.5
  2. Merge pull request #35 from glennpratt/travis

    billf committed Apr 11, 2014
    Support Travis-CI.
  3. Merge pull request #37 from draco2003/patch-1

    billf committed Apr 11, 2014
    mismatched function call and function signature.
Commits on Apr 10, 2014
Commits on Jan 25, 2014
  1. Support Travis-CI.

    glennpratt committed Jan 24, 2014
     - Add Makefile.local to fix make test's exit status.
Commits on Oct 24, 2013
Commits on Aug 9, 2013
  1. Merge pull request #23 from oliworx/patch-1

    scottmac committed Aug 9, 2013
    call graph: changed color of arrows/edges to grey for readability
  2. Merge pull request #25 from erikwebb/add-gitignore

    scottmac committed Aug 9, 2013
    Ignore build artifacts from Git
  3. Merge pull request #29 from robocoder/patch-2

    scottmac committed Aug 9, 2013
    fixes PR #20 when using randomly generated run ids
Commits on Jul 25, 2013
Commits on Jul 19, 2013
  1. Merge pull request #20 from robocoder/patch-1

    scottmac committed Jul 19, 2013
    filter 'run' parameter
Commits on May 2, 2013
Commits on Apr 21, 2013
Commits on Apr 10, 2013
  1. call graph: changed color of arrows/edges to grey for readability

    oliworx committed Apr 10, 2013
    call graph: changed color of arrows/edges to grey for better 
    readability of the labels
Commits on Apr 9, 2013
  1. Merge pull request #22 from c9s/numformat-fix

    billf committed Apr 9, 2013
    Numformat fix -- only run through callback if the value is numeric