Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

filter 'run' parameter #20

Merged
merged 1 commit into from Jul 19, 2013

Conversation

Projects
None yet
4 participants
Contributor

robocoder commented Mar 31, 2013

No description provided.

@scottmac scottmac added a commit that referenced this pull request Jul 19, 2013

@scottmac scottmac Merge pull request #20 from robocoder/patch-1
filter 'run' parameter
62638e0

@scottmac scottmac merged commit 62638e0 into phacility:master Jul 19, 2013

Bug,it makes '$run' empty!
change it to

$p = implode(',', array_filter(explode(',', $p), 'is_string'));

see line 891.

@robocoder robocoder added a commit to robocoder/xhprof that referenced this pull request Jul 22, 2013

@robocoder robocoder fixes PR #20 when using randomly generated run ids fc64300

This breaks the code for me, the run is hex, for me is_numeric returns false, it needs ctype_xdigit instead of is_numeric

@scottmac scottmac added a commit that referenced this pull request Aug 9, 2013

@scottmac scottmac Merge pull request #29 from robocoder/patch-2
fixes PR #20 when using randomly generated run ids
4bc36e7

@orbisnull orbisnull added a commit to orbisnull/XHProfiler that referenced this pull request Dec 25, 2013

@orbisnull orbisnull merge phacility/xhprof#20 29cb092

This was referenced Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment