Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

filter 'run' parameter #20

Merged
merged 1 commit into from

4 participants

@robocoder

No description provided.

@scottmac scottmac merged commit 62638e0 into phacility:master
@aiddroid

Bug,it makes '$run' empty!
change it to

$p = implode(',', array_filter(explode(',', $p), 'is_string'));

see line 891.

@robocoder robocoder referenced this pull request from a commit in robocoder/xhprof
@robocoder robocoder fixes PR #20 when using randomly generated run ids fc64300
@slava-vishnyakov

This breaks the code for me, the run is hex, for me is_numeric returns false, it needs ctype_xdigit instead of is_numeric

@orbisnull orbisnull referenced this pull request from a commit in orbisnull/XHProfiler
@orbisnull orbisnull merge phacility/xhprof#20 29cb092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 25, 2013
  1. @robocoder

    sanitize input

    robocoder authored
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 0 deletions.
  1. +4 −0 xhprof_lib/utils/xhprof_lib.php
View
4 xhprof_lib/utils/xhprof_lib.php
@@ -905,6 +905,10 @@ function xhprof_param_init($params) {
exit();
}
+ if ($k === 'run') {
+ $p = implode(',', array_filter(explode(',', $p), 'is_numeric'));
+ }
+
// create a global variable using the parameter name.
$GLOBALS[$k] = $p;
}
Something went wrong with that request. Please try again.