Add source list view and UI for selecting runs to compare. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just fixed the mismerge by doing rebase.. The code styling is also fixed. Please take a look. |
|
rebased too, please take a look. |
|
By the way, are you interested in a patch of putting highcharts in xhprof display ? |
|
highcharts sounds fine as long as its configurable |
|
cool, I will work for it on another branch. |
|
is there any concern of this pull request? |
|
any update here? |
- Add Makefile.local to fix make test's exit status.
mismatched function call and function signature.
Support Travis-CI.
Change inline to static inline for C99 compliance with PHP 5.5
|
if you're still interested in getting this in, please rebase/resolve/update and sign the contributor agreement at https://code.facebook.com/cla and i'll work with you on landing this. |
|
Hi, I just signed and rebased the changes, please take a look again. |
|
@epriestley care to review and merge? |
|
@guilhermeblanco , @epriestley do you want me to rebase the changes? |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.