Numformat fix #22

Merged
merged 2 commits into from Apr 9, 2013

Projects

None yet

2 participants

@c9s
c9s commented Apr 6, 2013

Since numformat function can not format strings like 'N/A', we need to check for the string value.

@billf

i think you need to rebase or something so this request only contains the new revisions

@c9s
c9s commented Apr 9, 2013

The pull request is updated by rebasing, please take a look.

@billf

really, this is

is_numeric($num)

because you still want "3" to succeed.

if (is_callable($fmt_func) && is_numeric($num)) {
  $num = call_user_func($fmt_func, $num);
}
@c9s

yeah that makes sense, let me update.

@c9s
c9s commented Apr 9, 2013

updated. please take a look.

@billf billf merged commit 254eb24 into phacility:master Apr 9, 2013
This was referenced Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment