Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixes PR #20 when using randomly generated run ids #29

Merged
merged 1 commit into from Aug 9, 2013

Conversation

Projects
None yet
4 participants
Contributor

robocoder commented Jul 22, 2013

👍 thanks!

scottmac added a commit that referenced this pull request Aug 9, 2013

Merge pull request #29 from robocoder/patch-2
fixes PR #20 when using randomly generated run ids

@scottmac scottmac merged commit 4bc36e7 into phacility:master Aug 9, 2013

This commit breaks if you pass iXHProfRuns::save_run() a simple string as third parameter.

Contributor

robocoder replied Aug 27, 2013

I can live with the restriction. I don't want to over-complicate it.

This was referenced Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment