Made sampling interval and call-stack tracing depth configurable via INI... #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call graph: changed color of arrows/edges to grey for better readability of the labels
fixes PR phacility#20 when using randomly generated run ids
Ignore build artifacts from Git
call graph: changed color of arrows/edges to grey for readability
|
@turchanov can you please sign the CLA located at https://code.facebook.com/cla |
Closed
|
Hi! We'd really love to use this; @turchanov is there any chance of you signing the CLA to get this merged? :) |
|
Ok, I just have signed the CLA. |
|
in the time between my comment above and now, ownership of xhprof transferred from facebook to phacility. the facebook CLA is no longer relevant and @epriestley has been maintaining this repo. |
|
Would love to use this |
|
So... Is any action still required from me or it's all up to xhprof maintainer now? |
|
@turchanov I extracted your changes into a fresh PR #80, because this one contains additional files. Hope it makes it easier for the maintainer to review and possibly merge. |
Closed
yazshel
pushed a commit
to FluentDevelopment/xhprof
that referenced
this pull request
Dec 3, 2020
Windows support phacility#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...-settings instead of being hard-coded because there are use cases where 0.1s sampling interval is too coarse and INT_MAX limit on call-stack trace depth gives overly verbose traces.