Proxy zend_compile_string() so that eval() compilation tme is profiled #5

Merged
merged 2 commits into from Mar 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

davidsklar commented Feb 16, 2012

If someone is using eval() then currently eval() compilation time is not included in xhprof results. This patch adds proxying for zend_compile_string() to change that.

include the "::" as part of the constant strlen("eval::") so the number at the end is less magical

Owner

davidsklar replied Mar 5, 2012

include the "::" as part of the constant strlen("eval::") so the number at the end is less magical

I'm happy to change this, but I did it the way it is to mirror the code in the existing hp_compile_file() function (line 1714). Let me know whether you would prefer consistency or magic-reduction.

consistency.

billf commented on d47a3ff Feb 23, 2012

this is unrelated to the pull request's purpose: to proxy eval()

Owner

davidsklar replied Mar 5, 2012

Would you like me to augment the pull request's description?

billf was assigned Feb 23, 2012

billf merged commit 270b75d into phacility:master Mar 13, 2012

billf was unassigned by davidsklar Jun 17, 2014

This was referenced Apr 26, 2015

Minasu referenced this pull request Jun 20, 2016

Open

Php 5.6 Error 500. #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment