[#14627] - Added more cookie tets

phalcon · Jan 5, 2020 · 7ef460a · 7ef460a
1 parent 8a3d4c4
commit 7ef460a
Show file tree

Hide file tree

Showing 24 changed files with 537 additions and 413 deletions.
diff --git a/tests/cli/Cli/Dispatcher/SetActionNameCest.php b/tests/cli/Cli/Dispatcher/SetActionNameCest.php
diff --git a/tests/cli/Cli/Dispatcher/SetHandlerSuffixCest.php b/tests/cli/Cli/Dispatcher/SetHandlerSuffixCest.php
diff --git a/tests/cli/Cli/Dispatcher/SetTaskNameCest.php b/tests/cli/Cli/Dispatcher/SetTaskNameCest.php
diff --git a/tests/cli/Cli/Dispatcher/SetTaskSuffixCest.php b/tests/cli/Cli/Dispatcher/SetTaskSuffixCest.php
diff --git a/tests/unit/Http/Cookie/ConstructCest.php b/tests/unit/Http/Cookie/ConstructCest.php
@@ -13,10 +13,14 @@
 
 namespace Phalcon\Test\Unit\Http\Cookie;
 
+use Phalcon\Http\Cookie;
+use Phalcon\Test\Fixtures\Traits\DiTrait;
 use UnitTester;
 
 class ConstructCest
 {
+    use DiTrait;
+
     /**
      * Tests Phalcon\Http\Cookie :: __construct()
      *
@@ -27,6 +31,11 @@ public function httpCookieConstruct(UnitTester $I)
     {
         $I->wantToTest('Http\Cookie - __construct()');
 
-        $I->skipTest('Need implementation');
+        $this->setNewFactoryDefault();
+        $this->setDiSessionFiles();
+
+        $cookie = new Cookie('test');
+        $I->assertInstanceOf(Cookie\CookieInterface::class, $cookie);
+        $I->assertInstanceOf(Cookie::class, $cookie);
     }
 }
diff --git a/tests/unit/Http/Cookie/GetNameCest.php b/tests/unit/Http/Cookie/GetNameCest.php
@@ -14,10 +14,13 @@
 namespace Phalcon\Test\Unit\Http\Cookie;
 
 use Phalcon\Http\Cookie;
+use Phalcon\Test\Fixtures\Traits\DiTrait;
 use UnitTester;
 
 class GetNameCest
 {
+    use DiTrait;
+
     /**
      * Tests Phalcon\Http\Cookie :: getName()
      *
@@ -28,8 +31,29 @@ public function httpCookieGetName(UnitTester $I)
     {
         $I->wantToTest('Http\Cookie - getName()');
 
-        $cookie = new Cookie('test-cookie');
+        $this->setNewFactoryDefault();
+
+        $name     = 'test';
+        $value    = "phalcon";
+        $expire   = time() - 100;
+        $path     = "/";
+        $secure   = true;
+        $domain   = "phalcon.ld";
+        $httpOnly = true;
+        $options  = ["samesite" => "Lax"];
+
+        $cookie = new Cookie(
+            $name,
+            $value,
+            $expire,
+            $path,
+            $secure,
+            $domain,
+            $httpOnly,
+            $options
+        );
+        $cookie->setDI($this->container);
 
-        $I->assertEquals('test-cookie', $cookie->getName());
+        $I->assertEquals($name, $cookie->getName());
     }
 }
diff --git a/tests/unit/Http/Cookie/GetPathCest.php b/tests/unit/Http/Cookie/GetPathCest.php
diff --git a/tests/unit/Http/Cookie/GetSecureCest.php b/tests/unit/Http/Cookie/GetSecureCest.php
diff --git a/tests/unit/Http/Cookie/GetSetDomainCest.php b/tests/unit/Http/Cookie/GetSetDomainCest.php
@@ -14,33 +14,51 @@
 namespace Phalcon\Test\Unit\Http\Cookie;
 
 use Phalcon\Http\Cookie;
+use Phalcon\Test\Fixtures\Traits\DiTrait;
 use UnitTester;
 
 class GetSetDomainCest
 {
+    use DiTrait;
+
     /**
-     * Tests Phalcon\Http\Cookie :: getDomain() / setDomain()
+     * Tests Phalcon\Http\Cookie :: getDomain()/setDomain()
      *
      * @author Phalcon Team <team@phalcon.io>
      * @since  2018-11-13
      */
-    public function httpCookieGetDomain(UnitTester $I)
+    public function httpCookieGetSetDomain(UnitTester $I)
     {
-        $I->wantToTest('Http\Cookie - getDomain() / setDomain()');
+        $I->wantToTest('Http\Cookie - getDomain()/setDomain()');
+
+        $this->setNewFactoryDefault();
+        $this->setDiSessionFiles();
+
+        $name     = 'test';
+        $value    = "phalcon";
+        $expire   = time() - 100;
+        $path     = "/";
+        $secure   = true;
+        $domain   = "phalcon.ld";
+        $httpOnly = true;
+        $options  = ["samesite" => "Lax"];
 
         $cookie = new Cookie(
-            'test-cookie',
-            'test',
-            time() + 3600,
-            '/',
-            null,
-            'phalcon.ltd'
+            $name,
+            $value,
+            $expire,
+            $path,
+            $secure,
+            $domain,
+            $httpOnly,
+            $options
         );
+        $cookie->setDI($this->container);
 
-        $I->assertEquals('phalcon.ltd', $cookie->getDomain());
-
-        $cookie->setDomain('phalcon.io');
+        $I->assertEquals($domain, $cookie->getDomain());
 
-        $I->assertEquals('phalcon.io', $cookie->getDomain());
+        $domain = 'phalcon.io';
+        $cookie->setDomain($domain);
+        $I->assertEquals($domain, $cookie->getDomain());
     }
 }