Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixing possible invalid reference in concat

  • Loading branch information...
commit f118bc591108adc6afe180f11d4b36ee08271375 1 parent 3874965
Phalcon authored
Showing with 3 additions and 16 deletions.
  1. +2 −0  .gitignore
  2. +1 −16 ext/kernel/operators.c
2  .gitignore
View
@@ -479,3 +479,5 @@ build/install2
ext/.DS_Store
ext/mvc/model/query/lemon
ext/mvc/model/query/parser.out
+ext/mvc/view/engine/volt/lemon
+ext/mvc/view/engine/volt/parser.out
17 ext/kernel/operators.c
View
@@ -58,22 +58,7 @@ void phalcon_concat_self(zval **left, zval *right TSRMLS_DC){
if (Z_TYPE_P(right) != IS_STRING) {
phalcon_make_printable_zval(right, &right_copy, &use_copy_right);
if (use_copy_right) {
- /*if (Z_REFCOUNT_P(right) > 0) {
- PHALCON_CPY_WRT_CTOR(right, (&right_copy));
- } else {
- ALLOC_ZVAL(d); \
- * = *v; \
- zval_copy_ctor(d); \
- Z_SET_REFCOUNT_P(d, 1); \
- Z_UNSET_ISREF_P(d);
- }
- if (d) {
- if (Z_REFCOUNT_P(d) > 0) {
- zval_ptr_dtor(&d);
- }
- } else {
- phalcon_memory_observe(&d TSRMLS_CC); \
- } \*/
+ right = &right_copy;
}
}

1 comment on commit f118bc5

Bryan Drewery

Please make a new tag next time and not retag. In the FreeBSD project we record the checksum of the release that is tracked. If the tag is moved, the checksum then fails and we don't know if it is compromised or intended. Even after updating the local checksum to the new tag, users may struggle to get the right version downloaded if they have the old downloaded still. Thanks!

Please sign in to comment.
Something went wrong with that request. Please try again.