Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Dispatcher::getParam return defaultValue if sanitized length is 0 #10866

Closed
lajosbencz opened this issue Aug 31, 2015 · 1 comment
Closed

[NFR] Dispatcher::getParam return defaultValue if sanitized length is 0 #10866

lajosbencz opened this issue Aug 31, 2015 · 1 comment
Labels

Comments

@lajosbencz
Copy link

@lajosbencz lajosbencz commented Aug 31, 2015

The current implementation of Dispatcher::getParam will only return the specified defaultValue if there is no such key in the parameters array.

If defaultValue argument is null, it should still return the sanitized value, even when empty.
If defaultValue is anything but null and the length of the sanitized parameter is 0, it should return the defaultValue.

This was referenced Aug 31, 2015
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Apr 17, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 17, 2018
@sergeyklay sergeyklay closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.