New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Asset management, make resource collection be a Set #10938

Closed
Dimous opened this Issue Sep 12, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@Dimous

Dimous commented Sep 12, 2015

I made widgets, that autoregister their own css/js. When I use multiple instances of a widget, its link/script entries get duplicated.

@Dimous

This comment has been minimized.

Show comment
Hide comment
@Dimous

Dimous Sep 13, 2015

This snippet reproduces resource registering behaviour of 10 instances of a widget:
for ($nIndex = 0; $nIndex < 10; ++ $nIndex) $this->assets->addCss("style.css")->addJs("script.js");

Dimous commented Sep 13, 2015

This snippet reproduces resource registering behaviour of 10 instances of a widget:
for ($nIndex = 0; $nIndex < 10; ++ $nIndex) $this->assets->addCss("style.css")->addJs("script.js");

KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 13, 2015

KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 25, 2015

KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 26, 2015

KorsaR-ZN added a commit to KorsaR-ZN/phalcon-core that referenced this issue Sep 26, 2015

@Dimous

This comment has been minimized.

Show comment
Hide comment
@Dimous

Dimous Aug 5, 2016

Oy vey! Feature #10938 is still not merged!

Dimous commented Aug 5, 2016

Oy vey! Feature #10938 is still not merged!

@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Aug 5, 2016

Member

It may be part of 3.1.0

Member

sergeyklay commented Aug 5, 2016

It may be part of 3.1.0

@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Jun 2, 2017

Member

Implemented in 3.2.x branch.

Member

sergeyklay commented Jun 2, 2017

Implemented in 3.2.x branch.

@sergeyklay sergeyklay closed this Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment