New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup session adapters #11341

Closed
sergeyklay opened this Issue Jan 24, 2016 · 4 comments

Comments

Projects
3 participants
@sergeyklay
Copy link
Member

sergeyklay commented Jan 24, 2016

It is necessary to clean all Session Adapters from statsKey copypasta.
The session adapters don't need this key.

This should be done in 2.1.04.0.0.

@dzubchik

This comment has been minimized.

Copy link
Contributor

dzubchik commented Feb 24, 2016

@sergeyklay , maybe milestone should be assigned to this issue?

@sergeyklay

This comment has been minimized.

Copy link
Member Author

sergeyklay commented Feb 25, 2016

how this will help

@dzubchik

This comment has been minimized.

Copy link
Contributor

dzubchik commented Feb 25, 2016

@sergeyklay , sure it will help! Just look at yii2 or symfony issue trackers:

It is easy to find out relations between issues and framework component, also it is clear to understand next release issues. So, when I, as developer, want to help I don't understand issues priority, except bug-high, bug-low. IMHO issue tracking is one of the primary things is OS projects and could help improve project continuously.

Yesterday I have browsed almost all issues in tracker and can say that here we definitely have problems:

  • a lot of issues to 1.x version - they can be resolved only by phalcon 1 developers
  • issues that have been resolved by pull request, but seemed to be open (from 2013 year) #10239
  • issues without participants #3158

Milestones, labels - things that could help to deal with such amount of issues.

@sergeyklay sergeyklay added this to the 4.0.0 milestone May 2, 2017

@sergeyklay sergeyklay referenced this issue May 2, 2017

Closed

Standardize the session interface #12833

0 of 6 tasks complete

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

@niden niden referenced this issue Oct 19, 2018

Merged

Reorganized/cleaned up Session classes #13538

2 of 3 tasks complete

@niden niden self-assigned this Nov 2, 2018

@niden niden added this to In progress in 4.0 Release Nov 28, 2018

@niden niden moved this from In progress to To do in 4.0 Release Nov 28, 2018

@niden niden moved this from To do to In progress in 4.0 Release Dec 21, 2018

@niden niden referenced this issue Dec 21, 2018

Merged

T12833 session interface #13673

3 of 3 tasks complete

@phalcon phalcon deleted a comment from stale bot Dec 21, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 21, 2018

Addressed in #13673

@niden niden closed this Dec 21, 2018

4.0 Release automation moved this from In progress to Done Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment