Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-7 support request & discussion #11789

Closed
rahuldroy opened this issue May 15, 2016 · 18 comments

Comments

Projects
@rahuldroy
Copy link
Contributor

commented May 15, 2016

PSR-7 has been an official standard for a while now. It would be awesome to support it!

I raised this very briefly in Slack. One of the ideas I raised was having a having a complete separate namespace just for this (similar to how Guzzle implemented it). Would like to hear your thoughts about this!


Refs:

@Jurigag

This comment has been minimized.

Copy link
Member

commented May 15, 2016

If you have any idea you can create PR.

@sergeyklay

This comment has been minimized.

Copy link
Member

commented May 15, 2016

First of all we have to refactor HTTP stack. For example HTTP Middlewares - at the moment Middlewares easy to use only for Micro application but they however do not implement PSR-7 stuff

@rahuldroy

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2016

@sergeyklay Can you please elaborate on that

@Jurigag

This comment has been minimized.

Copy link
Member

commented Aug 18, 2016

How about 4.0.0 this ?

@sergeyklay sergeyklay added this to the 4.0.0 milestone Aug 18, 2016

@xerron

This comment has been minimized.

Copy link

commented Sep 30, 2016

+1

@stoiev

This comment has been minimized.

Copy link

commented Dec 16, 2016

+1

1 similar comment
@grigoriy-ivanov

This comment has been minimized.

Copy link

commented Dec 17, 2016

+1

@xueron

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2017

+1

6 similar comments
@MoneyCoder

This comment has been minimized.

Copy link

commented Mar 19, 2017

+1

@hoyo

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2017

+1

@dibmartins

This comment has been minimized.

Copy link

commented Aug 1, 2017

+1

@C0DE8

This comment has been minimized.

Copy link

commented Sep 16, 2017

+1

@jasonraimondi

This comment has been minimized.

Copy link

commented Oct 13, 2017

+1

@lucasantarella

This comment has been minimized.

Copy link

commented Oct 25, 2017

+1

@CheckMater

This comment has been minimized.

Copy link

commented Nov 16, 2017

+1 we definitely need this, I'm bored to use the Wandu library

@olegatro

This comment has been minimized.

Copy link

commented Nov 23, 2017

+1

1 similar comment
@Ark4ne

This comment has been minimized.

Copy link

commented Nov 23, 2017

+1

@sergeyklay sergeyklay referenced this issue Jul 16, 2018

Closed

Create ROADMAP-4.0.md #13432

3 of 3 tasks complete

@niden niden added this to To do in 4.0 Release via automation Feb 5, 2019

@phalcon phalcon deleted a comment from stale bot Feb 5, 2019

@niden niden moved this from To do to In progress in 4.0 Release Mar 9, 2019

@niden niden referenced this issue Mar 9, 2019

Merged

T11789 PSR-7/ PSR-17 #13885

4 of 4 tasks complete

niden added a commit that referenced this issue Mar 12, 2019

T11789 PSR-7/ PSR-17 (#13885)
* [4.0.x] - Added unicode flag for email filter

* [#11789] - Changed the utility class to be a static one

* [#11789] - Added more PSR interfaces

* [#11789] - Added utility tests

* [#11789] - Changed the Utility class

* [#11789] - Added UriFactory and Uri methods

* [#11789] - Adjustments and tests

* [#11789] - Adjustments to the Uri component; Added more tests

* [#11789] - Added more tests

* [#11789] - Adjustments to the encoding

* [#11789] - Changes to rawurlencode/encoding

* [#11789] - Moved Uri to the Http\Message namespace; Stub implemention for ServerRequest

* [#11789] - Added tests for more code coverage

* [#11789] - Correcting method parameters for the interface

* [#11789] - Corrected interface

* [#11789] - Added Http\Message\Stream; Added test stubs; corrected some tests

* [#11789] - Added input stream, stream factory and adjustments to the stream

* [#11789] - Updating ext folder

* [#11789] - Adding test stubs

* [#11789] - Adding more tests for the new classes

* [#11789] - Added new classes with stubbed methods

* [#11789] - Updating ext folder

* [#11789] - Corrected interfaces

* [#11789] - Updating ext/

* [#11789] - Adjusted test for php 7.2/7.3

* [#11789] - Corrected Path processing

* [#11789] - Updating ext/

* [#11789] - Added test stubs for factories

* [#11789] - Adjustments to constructors

* [#11789] - Updating ext

* [#11789] - Added PSR-15 stubs and classes

* [#11789] - Updating ext/

* [#11789] - Added constructor tests for http\server

* [#11789] - Added fixtures/abstract server classes; Added more tests

* [#11789] - Updating ext/

* [#11789] - Enabling mor ereporting for unit

* [#11789] - Rearranging the code a bit

* [#11789] - Updated ext

* [#11789] - Minor modification to the PR template

* [#11789] - Added license/see information

* [#11789] - Corrections and additions (tests/code)

* [#11789] - Updating ext/

* [#11789] - Trying a different approach with an intermediate variable

* [#11789] - PHPCS

* [#11789] - Removing xdebug from travis

* [#11789] - Removed dollar sign from the variable

* [#11789] - Using inter variable

* [#11789] - Adjustments with intermediate vars for services

* [#11789] - Minor text change in docblocks

* [#11789] - Disabling static analysis temporarily

* [#11789] - Updating ext/

* [#11789] - Corrected di warning; Work on the stream; Trimmed code

* [#11789] - Updating ext/

* [#11789] - Added setStream in stream

* [#11789] - Zephir generate and fixed missed var

* [#11789] - Adjustments to the interfaces based on docblocks

* [#11789] - Adjusted tests

* [#11789] - Corrections

* [#13687] - Added testbed for quick testing using the server

* [#13687] - Set the Utility as static

* [#13687] - Adjusted tests

* [#13687] - Corrected the change to the Utility class

* [#13687] - Updating the changelog

* [#11789] - Trying a bug fix

* [#11789] - Assigned constructor data to variables

* [#11789] - Added helper arr

* [4.0.x] - Updating the ext folder

* [4.0.x] - Added Arr helper class

* Revert "[4.0.x] - Added Arr helper class"

This reverts commit f8153d3.

* Revert "[4.0.x] - Updating the ext folder"

This reverts commit 655eafe.

* [#13687] - Added Helper/Arr

* [#13687] - Added tests for Arr

* [#13687] - Corrections to the helper

* [#13687] - Removing mysql 5.7 temporarily

* [#13687] - Trying xenial build

* [#13687] - Updating ext folder

* Revert "[#13687] - Updating ext folder"

This reverts commit f18a967.

* Revert "[#13687] - Trying xenial build"

This reverts commit 07da593.

* [#13687] - Refactored locations for url/utils

* [#13687] - Updated references to url/utils

* [#13687] - Trying the build with mysql5.7 again

* [#13687] - Trying a different installation for mysql 5.7

* [#13687] - Trying to get the installation going of mysql 5.7

* [#13687] - Trying something different

* [#13687] - Trying xenial

* [#13687] - Re-enabling mysql; removing memcached

* [#13687] - Adding again memcached in the setup

* [#13687] - Removing xenial

* [#11789] - Corrected references to Arr, removed obsolete test

* [#11789] - Updating ext/

* [#11789] - Trying with protected method

* [#11789] - Server request - assigning vars from the constructor

* [#11789] - Adjustments for the build

* [#11789] - Added Number helper

* [#11789] - Correcting the constructor code for uploadedfile; Added more tests

* [#11789] - Minor corrections

* [#11789] - Updating ext

* [#11789] - Added constructor tests; corrected logic for stream parameter

* [#11789] - Work on the stream and tests oh tests...

* [#11789] - Updating ext/

* [#11789] - Rebuilding ext

* [#11789] - Adjusting tests based on file modes

* [#11789] - Corrections to the logic for opening streams

* [#11789] - Added getSize tests

* [#11789] - Added wrappers for php:// input/memory/temp

* [#11789] - Added test stubs and tests for the streams

* [#11789] - Updating ext again

* [#11789] - More tests and sample files

* [#11789] - Corrected tests with different modes

* [#11789] - More corrections

* [#11789] - Added more tests

* [#11789] - Adjustment to the sample file

* Correcting mcall reference

* [#11789] - Minor adjustments

* [#11789] - Adjustments to the tests and phpcs

* [#11789] - Adjustments/trimming code

* [#11789] - Adjusting ext

* [#11789] - Added more tests for streams

* [#11789] - ext update

* [#11789] - Made warning protected for Stream
Added more vars that need to be injected in the ServerRequest
Adjustments to the Stream
Added UTF-8 aware parse_url() method in Uri

* [#11789] - Tests for stream

* [#11789] - Corrections to the memory stream

* [#11789] - Tests for UploadFile - new and corrections

* [#11789] - Adjustments to moveTo

* [#11789] - Corrected logic in moveTo

* [#11789] - Added more tests for moveTo

* [#11789] - Work on getHeaders/ServerRequest

* [#11789] - Created abstract message/request classes to reuse code (no traits sadly)

* Update abstractrequest.zep

Used correct UriInterface to prevent:

Declaration of Phalcon\Http\Message\AbstractRequest::withUri(Phalcon\Http\Message\UriInterface $uri, $preserveHost = NULL): Psr\Http\Message\RequestInterface must be compatible with Psr\Http\Message\RequestInterface::withUri(Psr\Http\Message\UriInterface $logger, $preserveHost = NULL)

* [#11789] - Added more tests for serverrequest

* [#11789] - ServerRequest work

* [#11789] - Adjustments and corrections

* [#11789] - Adding more tests for the ServerRequest

* [#11789] - Corrections to withUri and added more tests

* [#11789] - More tests yay!

* [#11789] - Added with/without for headers

* [#11789] - Fixing some tests and withAddedHeader logic

* [#11789] - Response and response tests

* [#11789] - PHPCS

* [#11789] - Minor correction

* [#11789] - Implementation of the request; Tests; Correction to the factory

* [#11789] - Adjusted exception messages

* [#11789] - Removed method name from exception messages

* [#11789] - Added last tests for the stream factory

* [#11789] - Updated the changelog

* [#11789] - Removed obsolete files

* [#11789] - Indentation corrections and review related fixes

* [#11789] - Added PSR to composer; Reenabled xdebug in travis

* [#11789] - changing psr-7 to 0.6.0

* [#11789] - Updating the changelog for the helper classes

* [#11789] - Corrections based on review

* [#11789] - Fixing the isset
@niden

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

This has been implemented

@niden niden closed this Mar 12, 2019

4.0 Release automation moved this from In progress to Done Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.