Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]Handle exceptions by beforeException in whole dispatcher loop #11893

Closed
Jurigag opened this issue Jun 15, 2016 · 1 comment
Closed

[NFR]Handle exceptions by beforeException in whole dispatcher loop #11893

Jurigag opened this issue Jun 15, 2016 · 1 comment
Labels
stale Stale issue - automatically closed

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Jun 15, 2016

Currently beforeException event can catch exception only while executing action. How about adding ability to catch exception from whole dispatch loop, like if we throw for example exception in beforeExecuteRoute then it will be catch as well ? We just need to modify try catch block here - https://github.com/phalcon/cphalcon/blob/2.1.x/phalcon/dispatcher.zep#L586

Is there gonna be any problem if this try block will be much longer ?

Topic on forum with this problem:
https://forum.phalconphp.com/discussion/11823/catching-exceptions-from-dispatch-event-listeners

@stale
Copy link

stale bot commented Apr 17, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale Stale issue - automatically closed label Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue - automatically closed
Projects
None yet
Development

No branches or pull requests

2 participants