New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #12098

Open
sergeyklay opened this Issue Aug 5, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@sergeyklay
Member

sergeyklay commented Aug 5, 2016

  • Remove Phalcon\Mvc\Model\Criteria::order in favor of Phalcon\Mvc\Model\Criteria::orderBy
  • Remove Phalcon\Mvc\Model\Validator\* in favor of Phalcon\Validation\Validator\*
  • Remove Phalcon\Cache\Backend\Memcache in favor of Phalcon\Cache\Backend\Libmemcached
  • Remove Phalcon\Session\Adapter\Memcache in favor of Phalcon\Session\Adapter\Libmemcached
  • Remove Phalcon\Debug::getMajorVersion due to the fact that we never use this method
  • Remove Phalcon\Mvc\Collection::validationHasFailed
  • Remove calling Phalcon\Mvc\Collection::validate with object of type Phalcon\Mvc\Model\ValidatorInterface
  • Refactor *\Apc classes to drop APC in favor of APCu
    The apc extension is considered unmaintained and dead.
    See: http://php.net/manual/en/intro.apc.php
  • Remove Phalcon\Mvc\Micro\Lazyloader::__call in favor of Phalcon\Mvc\Micro\Lazyloader::callMethod
  • Remove Phalcon\Cli\Console::addModules in favor of Phalcon\Cli\Console::registerModules
  • The xcache support should be deprecated as xcache is not compatible with the often by default enabled opcache extension. The xcache will not available for PHP 7
  • Remove Phalcon\Dispatcher::setModelBinding in favor of Phalcon\Dispatcher::setModelBinder

@sergeyklay sergeyklay added this to the 4.0.0 milestone Aug 5, 2016

@sergeyklay sergeyklay changed the title from Remove Phalcon\Mvc\Model\Validator\* in favor of Phalcon\Validation\Validator\* to Remove deprecated code Aug 5, 2016

@Jurigag

This comment has been minimized.

Show comment
Hide comment
@Jurigag

Jurigag Aug 5, 2016

Member

I just wonder why we didn't did it in 3.0.0 already.

Member

Jurigag commented Aug 5, 2016

I just wonder why we didn't did it in 3.0.0 already.

@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Aug 5, 2016

Member

We just deprecated it in 3.0.0, but not removed

Member

sergeyklay commented Aug 5, 2016

We just deprecated it in 3.0.0, but not removed

@ruudboon

This comment has been minimized.

Show comment
Hide comment
@ruudboon

ruudboon Nov 29, 2016

Contributor

Will the Phalcon\Mvc\Model\Validation* be removed in 3.1? Don't see why we should keep it any longer. If it's deprecated I expect that it should still be possible to use. Don't think that's the case (#12178)

Contributor

ruudboon commented Nov 29, 2016

Will the Phalcon\Mvc\Model\Validation* be removed in 3.1? Don't see why we should keep it any longer. If it's deprecated I expect that it should still be possible to use. Don't think that's the case (#12178)

@Jurigag

This comment has been minimized.

Show comment
Hide comment
@Jurigag

Jurigag Nov 29, 2016

Member

Because of collection. It will be removed in 4.0.0

Member

Jurigag commented Nov 29, 2016

Because of collection. It will be removed in 4.0.0

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment